Comments (2)
Hello Andreu,
Thank you for reporting a bug. The bug you're observing is due to a single set of values which were being used to convert viscosity in degrees Barbey to other viscosity units. The UnivariateSpline method requires the x-values to be continuously increasing or it could not perform an interpolation. For only Barbey out of 47 viscosity scales supported, the scale is an inverse and so the degrees Barbey decreased while viscosity increased. In previous versions of SciPy the error would only be raised if an interpolation was tried, not on creation, and I never tried a conversion with Barbey as I was developing the converter. I have added custom handling for it.
After fixing that, there is also the removal of SciPy's C2K and friends I had to fix. This project cannot make use of the new convert_temperature method introduced in SciPy 0.18 as it supports older versions of SciPy. I have vendorized those functions in a new release of fluids.core, increasing the version of fluids that is required to use thermo to 0.1.68; its upgrade will be automatically installed when thermo is upgraded.
Note this release includes some big changes (which should not be user-facing) in the identifiers.py file, to lazy-load portions of the chemical database for faster startup and reduced memory use. Please report any breaks from previous behavior this may have introduced; I was not planning on a new release right now but I'd rather get a release out to fix this issue anyway.
The new thermo version is in PyPi, 0.1.38. Please close this bug if you can confirm thermo is working with SciPy 1.0.
Sincerely,
Caleb
from thermo.
Dear Caleb,
In the first place I would like to thank you for both your fast answer and the quality of it. Your library has been a game changing for me in terms of thermodynamic calculations.
Regarding the bug, your patch fixed the issue with Scipy 1.0.0. If I come across more bugs I'll do my best to report them.
Thank you again,
Andreu
from thermo.
Related Issues (20)
- Gas phase mixture enthalpy values decreasing with increased pressure HOT 3
- Data for CAS# 64742-48-9 (Petroleum Naptha) missing HOT 4
- Certain properties missing from nitrogen gas HOT 4
- Mixture diffusion coefficient HOT 1
- PT_surface_special fails for mixture PR78MIX due to missing Tc and Pc attributes HOT 1
- Example for P-T diagrams?
- Mercury density HOT 3
- air.lemmon2000_rho HOT 2
- ImportError: cannot import name 'horner' from 'chemicals.utils' HOT 2
- Proposal on lists/numpy array support
- Chemical serialize able HOT 3
- Issues for Zg calculation HOT 1
- SQLite Fail on threading HOT 4
- Stream generation for air - cas_id references different chemical and H_reactive is attempted to use in calculation, but is None HOT 2
- Thermo v. 0.2.26 flash_vl - Raising Exception on PH flash HOT 4
- Examples on Raoult's Law PT Flash
- Phase envelope fails for mixtures HOT 2
- HELP VaporPressure HOT 1
- Inconsistent "rhol_60Fs_mass" values for normal paraffins HOT 1
- Help with implementing binary excess enthalpy predictions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thermo.