Comments (4)
othercorey
commented on June 2, 2024
Looks like that assumes Collection. I'm not a big fan of these traits, but think we can fix this.
from cakephp.
othercorey
commented on June 2, 2024
Extending Collection outside of cake is not possible because we have logic that work sonly for Collection and only for the custom iterators that extend Collection like ExtractIterator.
Because ExtractIterator overrides, unwrap(), we cannot call getInnerIterator() on it.
from cakephp.
Zuluru
commented on June 2, 2024
Well, that's unfortunate. :-( I'll have to try to think of a way to encapsulate it instead of extending, I guess. The class should probably be marked as final?
from cakephp.
othercorey
commented on June 2, 2024
We have to change the iterators to not extend Collection to mark it final.
Will keep this open while we look into if the interfaces or inheritance can change in 5.1.
from cakephp.
Related Issues (20)
- NotFoundException is using the error500 template instead of the error400 template. HOT 7
- DateTime microseconds make it null on save HOT 1
- ErrorController::beforeRender not called HOT 11
- Problem formatting milliseconds using i18nFormat HOT 3
- RulesChecker::remove() HOT 4
- FormProtector failing with csrfSessionMiddleware
- Component integration testing is broken with PHPUnit 10.5 and php 8.2
- Schema setColumnType silent no-op HOT 3
- Tests have wrong Connection aliases if testing with fixtures with different connection name HOT 5
- Still a small issue on ObjectRegistry load aliasing HOT 6
- Breaking change cakephp/database HOT 10
- Strpos result comparison HOT 3
- Feature: Enum validation - subset
- Double loading of plugin HOT 1
- Extending base validation fails. HOT 3
- FormHelper - input number doesn't work HOT 2
- Configuring Connection with Driver instance legacy but not deprecated HOT 3
- CakePHP 4 Custom Routing Issue with Paginator Links HOT 2
- Stricter Command arg/option API HOT 3
- Strange side effects of 5.0.7 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cakephp.