Nested elseif indention is marked as invalid about cakephp-codesniffer HOT 13 CLOSED

That code example is missing all the braces. Except in view files, braces should always be used as it makes code easier to read.

from cakephp-codesniffer.

This is code we use in a view.

from cakephp-codesniffer.

The standards are not meant to cover view files.

from cakephp-codesniffer.

I know, but it used to work and since a recent pear upgrade-all it is broken.

from cakephp-codesniffer.

Well it's coincidental it worked for your views. Either stop using it for views or update your code to make the sniffer happy :)

I don't think it's a good idea to change the sniffs to cater to files it wasn't meant to cover in the first place.

from cakephp-codesniffer.

This is code we use in a view.

The only way that syntax is supposed to be used in a view is e.g.:

<?php if ($whatever): ?>
...
<?php elseif($somethingelse): ?>

Which isn't the syntax you're using.

But as ADmad has said, the standard isn't intended to be ran on view files

from cakephp-codesniffer.

Closing as the standard is not intended to accept the syntax in the question.

from cakephp-codesniffer.

@AD7six Fine, but the above syntax does not work either if it's nested...

from cakephp-codesniffer.

www-data @ dev [ /tmp ]
-> cat foo.php 
<?php
$a = 'a';
if (!empty($a)) {
    $b = 'b';
    if ($b === 'c') {
        $c = 'e';
    } elseif ($b === 'd') {
        $c = 'f';
    } else {
        $c = 'g';
    }
}
www-data @ dev [ /tmp ]
-> phpcs --standard=CakePHP foo.php 
Time: 68 ms, Memory: 3.00Mb

www-data @ dev [ /tmp ]
-> 

It works fine.

from cakephp-codesniffer.

But this one:

<?php $a = 'a'; ?>
<p>a</p>
<?php if (!empty($a)): ?>
    <p>c</p>
    <?php if ($b === 'c'): ?>
        <p>d</p>
    <?php elseif ($b === 'd'): ?>
        <p>e</p>
    <?php else: ?>
        <p>f</p>
    <?php endif; ?>
    <p>g</p>
<?php endif;

not.

from cakephp-codesniffer.

that's not supposed to pass... that syntax is appropriate for a view file which the standard is not designed to be used on.

from cakephp-codesniffer.

What about this test?

from cakephp-codesniffer.

A left over from before we restricted the standard to be used with php files only.

from cakephp-codesniffer.