Wrong duplication check in SluggableBehavior about utils HOT 4 CLOSED

Which branch are you using? I've added a few more tests and I can not verify this wrong behaviour in the develop branch. Tests in master branch pass also.

Can you please provide a test case for that in a pull request? Thank you.

from utils.

I downloaded the Master branch on 2012-12-27. But I see it was fixed in the develop branch a while ago.

See: #49.

Master branch is still wrong though, tests are also incomplete:

/**
 * Test save unique
 *
 * @return void
 */
    public function testSaveUnique() {
        $this->Model->create(array('title' => 'Fourth Article'));
        $this->Model->save();
        $this->Model->create(array('title' => 'Fourth Article!!'));
        $this->Model->save();
        $this->Model->create(array('title' => 'Fourth "Article"'));
        $this->Model->save();

        $results = $this->Model->find('all', array('conditions' => array('title LIKE' => 'Fourth%')));
        $this->assertEqual(count($results), 3);
        $this->assertEqual($results[0]['SluggedArticle']['slug'], 'fourth_article');
        $this->assertEqual($results[1]['SluggedArticle']['slug'], 'fourth_article_1');
        $this->assertEqual($results[2]['SluggedArticle']['slug'], 'fourth_article_2');
    }

If you'd add a fourth create with just "Fourth" as a title, the slug will be "fourth_1" instead of "fourth".

from utils.

I'll try to do a merge to master until the end of the week. There are a few other things that need to be done in the plugin before we can merge it to master.

Thanks for the detailed error report! :) 👍

from utils.

This has been fixed in the develop branch, see also the tests for it.

from utils.