GitHasStagedChanges only considers modified files, not new/deleted/renamed about cake_git HOT 3 OPEN

@andreasnilsen to not break anything, perhaps add an GitHasChanges alias that checks all places?

from cake_git.

@devlead I understand your concern, but imho that name is a bit vague, it's not intuitive to me how it relates to/differs from GitHasUncommitedChanges (which will consider any file that is not ignored or unaltered as a change, including both unstaged and staged files), and some people are already using the existing method in the belief that it will consider all staged files. How about GitHasIndexedChanges, which was the original name of the GitHasStagedChanges? And maybe mark GitHasStagedChanges for deprecation?

Or maybe give it an optional flags enum for the places as an argument, which defaults to only modified files, i.e. current the functionality?

from cake_git.

I also ran into this today when pushing to my gh-pages branch for the first time. I've replaced it with GitHasUncommitedChanges but this is not ideal either as this doesn't necessarily mean the changes have been staged.

from cake_git.