Split CloudKit requests into smaller chunks about icecream HOT 6 CLOSED

@IngmarStein @harryworld @insidegui

Gentlemen, I've received a pull request from @randycarney and made lots of changes to that. And I am really happy to announce that:

IceCream is equipped with a powerful ErrorHandler now!

For the details, you guys could take a look the #15. In that pr, ErrorHandler has taken care of all the error codes that CloudKit returns.

Check it now! Thanks to all of you.

from icecream.

In practice, we always handle these following errors:

1. limitExceeded 400 records per operation, or 2MB per request -> Split it
2. quotaExceeded iCloud space is used up -> Show alert message
3. partialFailure in case of using default savePolicy

In addition, one may optionally handle the unrecoverable errors like

1. unknownItem
2. internalError

from icecream.

@caiyue1993 This can be fixed by splitting the items into batches of at most 400 at a time.

from icecream.

@IngmarStein Thanks a lot for raising this issue and detailed suggestions! IceCream library truly should handle this case.

And yep, we could fix this by the way @insidegui suggested.

I'm on it and keep tuned.

from icecream.

@harryworld I appreciate it a lot!

Thanks for you practical advice and I'll check out my code. 👍

from icecream.

I just submitted a pull request from my fork CKErrorHandler to address the errors specifically where appropriate, based on the error handling from the GitHub library EVCloudKitDao: https://github.com/evermeer/EVCloudKitDao.

It basically divides all the potential CKError codes into CKErrorTypes that you can switch on and handle with custom code.

 public enum CKErrorType {
        case success
        case retry(afterSeconds: Double)
        case recoverableError(reason: CKFailReason)
        case chunk
        case fail(reason: CKFailReason)
    }

public enum CKFailReason {
        case changeTokenExpired
        case quotaExceeded
        case partialFailure
        case serverRecordChanged
        case shareRelated
        case unhandledErrorCode
        case unknown
    }

It also provides a NSLog message copied from the Apple Documentation that could be turned into a button to notify the user easily.

I implemented CKErrorHandler in all the places in SyncEngine it would be currently appropriate as far as I can tell.

I also made the CKModifyRecordsOperation .isAtomic flag true to avoid CKError.partialFailure errors, though some may want to handle those specifically.

Let me know what you think!

from icecream.