Git Product home page Git Product logo

Comments (6)

Cacodaimon avatar Cacodaimon commented on September 17, 2024

It's a good idea but I would move it the new Milestone v2?

from ghosttext-for-chrome.

fregante avatar fregante commented on September 17, 2024

Rather than a "blacklist" that disables GT completely, we might just inform the use that the site is know to be problematic and GT might not behave as expected

from ghosttext-for-chrome.

Cacodaimon avatar Cacodaimon commented on September 17, 2024

What do you think about this data structure?

{
    'example.com': {severity: 'LOW', info: 'Disqus comments are not supported.', date: 1234567890},
    'foo.bar': {severity: 'HIGH', info: 'GhostText won't work :( !', date: 1234567890},    
}

from ghosttext-for-chrome.

fregante avatar fregante commented on September 17, 2024

Why the date? Should we show it to the user?

We should never completely disable GT functionality, a warning about "it may not work as intended" might be enough.

Should we add a "suggest a fix" link to a Github issue?

from ghosttext-for-chrome.

fregante avatar fregante commented on September 17, 2024

If someday we get to solve issue #25, we might use that information to detect IPboard and show the notice I suggested in #33

from ghosttext-for-chrome.

Cacodaimon avatar Cacodaimon commented on September 17, 2024

Why the date? Should we show it to the user?

The date is only for internal use and makes detecting when this host/system was added to this list, without searching the git history, easier.

We should never completely disable GT functionality, a warning about "it may not work as intended" might be enough.

You are right, I thought we could use the severity for the hummane.js message color, LOW -> white and HIGH -> red… . If it is only a issue like this "TextArea chrome highlighting bug #33" we don't need to scare the user.

Should we add a "suggest a fix" link to a Github issue?

👍 Great idea!

If someday we get to solve issue #25, we might use that information to detect IPboard and show the notice I suggested in #33

Yeah we have to solve #25 first before starting with this issue.

The data structure should mybe splitted into hosts (facebook.com…) or systems (wordpress…).

{
    hosts: {
        'example.com': {severity: 'LOW', info: 'Disqus comments are not supported.', date: 1234567890},
        'foo.bar': {severity: 'HIGH', info: 'GhostText won't work :( !', date: 1234567890},    
    },
    systems: {
        'i-p-s-board': {severity: 'LOW', info: 'IPboard is buggy with GT. To avoid it, close the connection before opening a new file.', date: 1234567890}, 
    },
}

from ghosttext-for-chrome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.