Git Product home page Git Product logo

Comments (5)

bzikarsky avatar bzikarsky commented on August 22, 2024

Checkout https://github.com/bzikarsky/gelf-php/blob/master/src/Gelf/MessageValidator.php#L24 - it's passed by reference.

Did you run in any issues with that?

from gelf-php.

bzikarsky avatar bzikarsky commented on August 22, 2024

Is this issue still relevant @MaximeBaldin? If not, please close the issue (or I will, the next time I come by it 😉)

from gelf-php.

maxbaldin avatar maxbaldin commented on August 22, 2024

@bzikarsky, from where $reason is taken in the method call?
It is not declared in this method https://github.com/bzikarsky/gelf-php/blob/master/src/Gelf/Publisher.php#L61.

My IDE highlights $this->messageValidator->validate($message, $reason) because of undefined $reason. This is about this issue.

from gelf-php.

bzikarsky avatar bzikarsky commented on August 22, 2024

Then your IDE is not correct - PHP does not require a passed-by-reference variable to be defined before the function call.

This behavior is true for all versions of PHP5 and HHVM: http://3v4l.org/KjO8T

from gelf-php.

maxbaldin avatar maxbaldin commented on August 22, 2024

You are right.
Thanks for reply.

from gelf-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.