Error executing modules about deathstar HOT 15 CLOSED

Ive pretty much given up for now, tbh.

from deathstar.

I am also getting a similar error

from deathstar.

It turns out that these modules inside Empire no longer have a few options.
For example: the "Threads" option has been removed. So when DeathStar passes some of those removed properties, error.
I'm editing Deathstar.py right now to see if I can create a workaround.

from deathstar.

That is great - thank you!

from deathstar.

NOOOO! Totally understand though....

from deathstar.

If you comment the whole thing like
module_options {
#things1
#things2
}
it stops giving you an error, then the next module does the same. If you go repeating the process you'll end eventually somewhere.
BUT
since many things actually depend on user_hunter and get_group_name, you're toast

from deathstar.

That sucks... I will also take a look later when I get some time to see if there is a possible solution...

from deathstar.

A few of them only return error because they use Threads and NoPing, which are no longer available on Empire. Those will work if you comment both module_options lines. I think "find_localadmin_access" is an example.

I'm pretty sure the Red Line saying something wrong with the Agent and not finding many things on those scans are both a cause of my comments.

Then again, I'm only testing.

from deathstar.

Confirmed that the modules that return most of the user and group names are not working thanks to my comments. That's why a good part of the enumeration doesn't find anything.
But GroupName = group_name absolutely does not work. Or anything similar.

I can investigate those modules and check how they manage the IDs and names, but oh boy.

from deathstar.

I guess Empire changed a lot of crap
Thank you for taken the time though

from deathstar.

Just want to report that today I did some testing
Deathstar doesn't find any domain admin (my shell is a domain admin)
then it runs mimikatz and finds the very account I'm using
then it says it can't find domain admins
then it runs mimikatz and finds the very account I'm using

oh you get it. Eternal-agent-making-loop =)
that module is broken, or just our parameters.

from deathstar.

I haven't had a chance to look yet but hopefully I can over the weekend and see if I can figure anything out

from deathstar.

I've been working on this all day. Fixing the module options is easy and I've deleted the nonexistant module options and replaced them with the right ones. At this point, it seems to be a parsing issue of module output. Like get_domain_sid returns only "Job started xxx" output for some reason.

from deathstar.

I have fixed everything I think. I found more bugs in Empire than I did in DeathStar...

Check my fork or just wait til byt3bl33d3r accepts the PR which I think he'll do pretty quickly.

from deathstar.

#50 should have resolved this, if not comment below. Thanks again @DanMcInerney !

from deathstar.