Comments (7)
I am glad to know that it is aligned with the Dokku project.
The change you ask for is not difficult at all. There is one place I have to change. But I have to make some changes in the documentation, add new unit tests, create an environment variable to make it customizable, etc.
Before putting my hands on it, I'd like to understand why the label rename can positively impact the APP.
from docker-easy-haproxy.
While not now, I figure that in the future, it may be possible for users to customize other parts of the haproxy config via app labels. They might do so like this:
dokku docker-options:add node-js-app deploy "--label easyhaproxy.some-key=value"
The proxy plugin itself would be named haproxy
, so it would make sense for someone to run this instead:
dokku docker-options:add node-js-app deploy "--label haproxy.some-key=value"
All other plugin integrations use the underlying service name (caddy or traefik) as the label prefix. I'd like to avoid a user bashing their head in because they used the wrong prefix.
from docker-easy-haproxy.
OK. I'll do that. Probably next week have that. So, just to let you know, the default will be easyhaproxy
, and we will be able to override it by setting an environment variable in the easyhaproxy container. Does it make sense?
from docker-easy-haproxy.
OR... are you planning to integrate inside the Dokku project as part of the project? If you are planning to do that, I can change the default to haproxy
.
from docker-easy-haproxy.
No I'm going to start your container via a custom compose file. I can reconfigure it as necessary :)
from docker-easy-haproxy.
I added PR #14 with the requirements you ask. You have to add the environment variable LOOKUP_LABEL
to your easyhaproxy container.
Here is an example: https://github.com/byjg/docker-easy-haproxy/blob/73ced05228c6342444bff6e121ed86cd6460d443/examples/docker/docker-compose-changed-label.yml
I still have to do some work to package it, but you can start your tests if you want.
from docker-easy-haproxy.
All merged. You can docker pull byjg/easy-haproxy:4.0.0
. See release notes of the implemented features: https://github.com/byjg/docker-easy-haproxy/releases/tag/4.0.0
from docker-easy-haproxy.
Related Issues (20)
- Which networks are scanned? HOT 3
- Add letsencrypt integration HOT 4
- Make the definitions part of the label the second part instead of the end HOT 2
- Add ability to disable the stats port HOT 10
- How do we handle multiple domains? HOT 2
- Add a way to configure log-level HOT 3
- Add ability to override the letsencrypt server HOT 3
- Use container ip instead of container name when using the default bridge network HOT 5
- Using labels to configure haproxy running on a different host HOT 6
- Docker Swarm error: Service cannot be explicitly attached to the ingress network "ingress" HOT 9
- Enable HTTP/2 over HTTPS HOT 8
- Certbot Continues Requests Despite Hitting Let's Encrypt Certificate Rate Limit HOT 21
- Support Custom Configuration Files + Custom LoadBalance
- Crash when a container with `network_mode: host` is running HOT 3
- Certbot not working: connection refused HOT 5
- HTTP/3 HOT 1
- [FEATURE REQUEST] Custom defaults, frontend and backend configuration HOT 5
- Create Plugins for EasyHAProxy
- question about redirects HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-easy-haproxy.