CMake policy error when checking library component Geant4 with `find_dependency()` about bxdecay0 HOT 9 CLOSED

You' re welcome. I'll do it ASAP.
Do you agree if I add the remage project in the list of supporters and pin its logo ?

from bxdecay0.

Hi Luigi,

Strange behaviour indeed. Have you tried to use:
cmake_policy(SET CMP0057 NEW)
in your own CMake script ?
Or maybe there is a hidden cmake_policy(SET CMP0057 OLD) command somewhere in your CMake setup
and you have not noticed it...

In case you cannot make it work with the above ideas, maybe you could modify the BxDecay0Config.cmake script
at line 69 with something like the following (not checked on my side):

  list(FIND ${_BxDecay0_supported_components} ${_requested_comp} _found_component_index)
  if (${_found_component_index} EQUAL -1) # Requested component is not supported in this BxDecay0's build
    set(BxDecay0_FOUND False) # So we fail
    set(BxDecay0_NOT_FOUND_MESSAGE "Unsupported component: ${_requested_comp}") # And report
  endif()

And please report !

Hope it helps

Regards
frc

from bxdecay0.

I've checked that I request only CMake 3.8 to build BxDecay0 but in that case I should enforce the 0057 policy to NEW.
So there is an issue on my side to be fixed here.
Anyway, I wait for your feedback.
Regards
frc

from bxdecay0.

I've checked that I request only CMake 3.8 to build BxDecay0 but in that case I should enforce the 0057 policy to NEW.

This is also what I understand from the docs: https://cmake.org/cmake/help/v3.8/policy/CMP0057.html. Still there's something odd, by the way. I honestly don't get why the error does not show up when calling find_package() in CMakeLists.txt.

In any case, I just tried adding cmake_policy(SET CMP0057 NEW) to cmake/BxDecay0Config.cmake.in and it fixes it.

from bxdecay0.

Hi, any news on the issue? It's a bit critical for my application. I can open a pull a request if you want.

from bxdecay0.

Hi Luigi

I've read again the doc at https://cmake.org/cmake/help/latest/policy/CMP0057.html and it states:
This policy was introduced in CMake version 3.3. CMake version 3.21.2 warns when the policy is not set and uses **OLD** behavior. Use the cmake_policy() command to set it to OLD or NEW explicitly.

So we should not except this IN_LIST token to be accepted by default in an 'if()'
with a recent version of CMake.
This is what you face AFAIU. Anyway, there is something odd which remains with the G4 extension. Probably the policy is forced somewhere in the G4's CMake scripts from the find_package(Geant4 10.6.3 REQUIRED).

For now, I propose to add the cmake_policy(SET CMP0057 NEW) line in the BxDecayConfig.cmake.in file. I'll commit in the dev branch and I'll tag if I get your green light.

from bxdecay0.

Hi, thanks a lot for fixing this. I just tested it and and the original issue with my software is solved. Would be great if you could make a new release now!

PS: I packaged bxdecay0 for Arch Linux and uploaded on the Arch User Repositories (AUR): https://aur.archlinux.org/packages/?O=0&K=bxdecay0. I will try to keep them up to date. If you think it's an interesting info for the bxdecay0 user base, you could mention this in the README.

Thanks!

from bxdecay0.

Sure, no problem! Though the project is still in a super early state now and it's not guaranteed that is will survive the R&D phase ;)

from bxdecay0.

Done at 1.0.11.

from bxdecay0.