Incorrect volume size when creating volume on disk partition about tc-play HOT 2 CLOSED

I'm a bit at a loss here. Can you try with the following patch and tell me what it says?

Oh boy, that makes no sense, my patch. not my day. Here is an updated one:

diff --git i/io.c w/io.c
index a862422..998d9d7 100644
--- i/io.c
+++ w/io.c
@@ -294,6 +294,8 @@ get_disk_info(const char *dev, disksz_t *blocks, size_t *bsize)
    *blocks = (disksz_t)(nbytes / blocksz);
    *bsize = (size_t)(blocksz);

+   printf("dev: %s, nbytes: %ju, blocksz: %d, blocks: %ju\n", dev, nbytes, blocksz, (uint64_t)*blocks);
+
    close(fd);
    return 0;
 }

from tc-play.

It appears this bug is not present in the latest sources. I downloaded the .zip from github and compiled it with your printf, and that version does the right thing.
I also noticed that tcplay v1.1 from the Debian repo states it will "Completely erase EVERYTHING on /dev/sdb1" when -z is specified; the locally compiled tcplay does not.
Closing this bug.

root@dmz1:~/bin# fdisk -l /dev/sdb

Disk /dev/sdb: 500.1 GB, 500107862016 bytes
81 heads, 63 sectors/track, 191411 cylinders, total 976773168 sectors
Units = sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disk identifier: 0x000098ec

Device Boot Start End Blocks Id System
/dev/sdb1 2048 976773167 488385560 83 Linux
root@dmz1:~/bin# ./tcplay -c -d /dev/sdb1 -z
dev: /dev/sdb1, nbytes: 500106813440, blocksz: 512, blocks: 976771120
Passphrase:
Repeat passphrase:
Summary of actions:

• Create volume on /dev/sdb1

  Are you sure you want to proceed? (y/n) y
  Creating volume headers...
  Depending on your system, this process may take a few minutes as it uses true random data which might take a while to refill
  Writing volume headers to disk...
  All done!
  root@dmz1:~/bin# tcplay -i -d /dev/sdb1
  Passphrase:
  Device: /dev/sdb1
  PBKDF2 PRF: RIPEMD160
  PBKDF2 iterations: 2000
  Cipher: AES-256-XTS
  Key Length: 512 bits
  CRC Key Data: 0x6c0e771b
  Sector size: 512
  Volume size: 976770608 sectors
  IV offset: 256
  Block offset: 256

root@dmz1:~/bin# /usr/sbin/tcplay -c -d /dev/sdb1 -z
Passphrase:
Repeat passphrase:
Summary of actions:

• Completely erase EVERYTHING on /dev/sdb1

• Create volume on /dev/sdb1

  Are you sure you want to proceed? (y/n) y
  Creating volume headers...
  Depending on your system, this process may take a few minutes as it uses true random data which might take a while to refill
  Writing volume headers to disk...
  All done!
  root@dmz1:/bin# tcplay -i -d /dev/sdb1
  Passphrase:
  Device: /dev/sdb1
  PBKDF2 PRF: RIPEMD160
  PBKDF2 iterations: 2000
  Cipher: AES-256-XTS
  Key Length: 512 bits
  CRC Key Data: 0xf7458bf9
  Sector size: 512
  Volume size: 3692080 sectors
  IV offset: 256
  Block offset: 256
  root@dmz1:/bin# /usr/sbin/tcplay --version
  tcplay v1.1
  root@dmz1:~/bin# ./tcplay --version
  tcplay v2.0

from tc-play.