Git Product home page Git Product logo

Comments (6)

bvaughn avatar bvaughn commented on May 5, 2024

Thanks for reporting this @crzrcn. Good eye. :) I'll see if I can fix it in a patch release.

from react-virtualized.

bvaughn avatar bvaughn commented on May 5, 2024

Hm. I wonder if this is a font metrics issues. I'm not seeing this behavior locally.

Can you give me some more information (browser, version, font family/size, etc.)

from react-virtualized.

 avatar commented on May 5, 2024

Browser: Chromium 43, Chrome 47, Firefox 40-42.
Font family: Roboto, 'Open Sans', sans-serif
Font size: 14px
Font weight: normal

from react-virtualized.

bvaughn avatar bvaughn commented on May 5, 2024

Note to self: we chatted about this and I think the fix is to change the inner overflow: hidden to overflow: visible so that certain line-height values won't clip the text. Need to experiment a bit and make sure this is a safe change but I think it should be.

from react-virtualized.

bvaughn avatar bvaughn commented on May 5, 2024

I think... after further examination... that this issue is being caused by a project-specific style (not something in react-virtualized). I believe if you remove the line-height: 1 style then things should work as expected (no clipping).

Looks like most browsers use a default line-height of around 1.2 depending on the font-family.

from react-virtualized.

bvaughn avatar bvaughn commented on May 5, 2024

I'm going to close this issue as working-as-intended unless I hear differently.

from react-virtualized.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.