Add support for dynamic row heights via :rowHeightGetter about react-virtualized HOT 10 CLOSED

+1

from react-virtualized.

For anyone following along on this issue, PR #37 is coming along nicely. Would have been finished already if not for the holidays but I hope to have it wrapped up by the end of the weekend.

from react-virtualized.

Resolved via PR #37

from react-virtualized.

@bvaughn Just so I understand it clearly, the idea here is that instead of a fixed height, one passes a function that determines the height for that row? And every time, the height of a child row changes, it should update its 'smart' parent container which hosts this rowHeightDeterminant function?

from react-virtualized.

Right. The rowHeight property can now be a number (for fixed heights) or a function that returns a height for a given row-index (for dynamic heights).

If a child row's height changes you may need to call recomputeRowHeights as mentioned in the docs (depending on whether that change is accompanied by other props changes).

You can see some example source code I wrote (used to create the demo page) here:
https://github.com/bvaughn/react-virtualized/blob/master/source/VirtualScroll/VirtualScroll.example.js

from react-virtualized.

@bvaughn Is recomputing row heights a deprecated feature? Given the situation:

<Parent>
  <List
    {...props}
    rowHeight={this.getRowHeight}
    {...parent.state}
  />
</Parent>

is it possible for a change to the parent's state not only re-render the children in the render method—per as mentioned in the section of pure components—but also trigger a recalculation of the rowHeights?

from react-virtualized.

Probably.

There isn't really enough info here for me to answer.

What have you tried? Where's the code? What version of RV are you using? (If it's really old, as your wording suggests, then that's probably an important detail).

Stack Overflow is probably better for this sort of question :)

from react-virtualized.

Just figured I’d ask here given there used to be a recomputeRowHeights method. Now it’s not documented anywhere, nor does there seem to be a documented alternative. Using the latest LTS version.

EDIT: Read latest major version (v9.x.x) rather than Long Term Support version.

from react-virtualized.

Just figured I’d ask here given there used to be a recomputeRowHeights method. Now it’s not documented anywhere, nor does there seem to be a documented alternative.

What documentation are you looking at? recomputeRowHeights is documented here.

Using the latest LTS version.

"LTS" ? I'm not sure what this means.

Anyway, GitHub issues are meant for bug reports and feature-requests. It's hard to scale questions, especially if there's not much information (as is the case here).

from react-virtualized.

Didn’t see those docs, thank you 🙏

from react-virtualized.