Mark required fields about angular-form-for HOT 9 CLOSED

Thank you! I'm happy to hear it!

I like this suggestion. Look for it in the next point release. I'll update you by way of this ticket when it's available.

from angular-form-for.

Fixed and available in 1.1.9

from angular-form-for.

FYI

https://github.com/bvaughn/angular-form-for/wiki/FormForConfiguration-Reference#setrequiredlabel

from angular-form-for.

That was fast, thank you ! I will try this very soon :)

from angular-form-for.

Hey,

this works great when the field has no other validation rules, but in the case where it has a validation rule like pattern, it adds the required label (even if I specify required: false)

I found that it is the binding of the required attribute on the field-label directive that has a problem. $scope.required equals to "false" and is not a boolean any more, thus passing through the "if ($scope.required) {" condition

I will try to find a solution to this problem if you don't have the time to correct it

from angular-form-for.

D'oh! Apparently I naively assumed that no one would bother to specify required: false (since that's the default). I'm in the middle of a pretty big feature at the moment (#19) but I'll make sure this fix is rolled into the upcoming release. Hopefully later today!

(In the meanwhile I'll re-open the request)

from angular-form-for.

Fixed in the new 1.2.0 release. :)

from angular-form-for.

Great :)

I just spotted one error that prevent fields to be correctly marked

In https://github.com/bvaughn/angular-form-for/blob/master/source/directives/form-for.js at line 115, I think it should be $scope.$validationRules instead of $scope.validationRules

from angular-form-for.

Thanks for pointing this out! :)

Here you go:
https://github.com/bvaughn/angular-form-for/releases/tag/1.2.1

On Wed, Aug 20, 2014 at 7:26 AM, pierre-michalet [email protected]
wrote:

Great :)

I juste spotted one error that prevent fields to be correctly marked

In
https://github.com/bvaughn/angular-form-for/blob/master/source/directives/form-for.js
at line 115, I think it should be $scope.$validationRules instead of
$scope.validationRules

Reply to this email directly or view it on GitHub
#15 (comment)
.

Thanks,
Brian Vaughn
p. 540-246-5223

from angular-form-for.