Comments (4)
In a game of wack-a-mole, if I config Combres to use msajax JS minifier then the public side of my site that caused the exception in the opening issue statement works fine. However, now the admin side of my site appears to not minify the JS correctly and this ends up with a JS syntax error that then prevents jQuery from working and thus the site fails to work correctly.
from combres.
It looks like the minifier can't parse the JS. Maybe try with a different minifier to see if any luck? There are 3 JS minifiers in total.
Besides, I haven't updated Combres for a while so it's stuck with old version of minifier. Would be great if someone could bump the version of both CSS and JS minifiers, I'd be happy to review a PR and coordinate to update NuGet.
from combres.
I tried the msajax one which works for the public area but then fails for the admin area.
The other minifier didn't work at all.
I manage to figure it out in the end. The problem with the YUI (default) minifier was that our JS was using some ECMAScript 6 syntax - specifically "() => { function code }" and "(event) => { function code }". Converting this JS to something like "function() { func code }" and "function(event) { func code}" solved the issue.
So it seems like none of the minifiers can correctly parse the latest JS standards correctly and if they can they fail for other reasons. I didn't figure out the other reasons because of the above change working so I was able to stick with the default minifier.
from combres.
I see. The minifiers are very out of date, I'm sure the latest version would work. That being said, I don't even have a window box these days to build and test. So if anyone wanting to contribute, I'll add as collaborator on this repo.
from combres.
Related Issues (20)
- Change in the URL format HOT 7
- Syncronization of last modified date on the response header. HOT 1
- Caching, versioning, and CDNs HOT 3
- Support mixing Less and CSS in the same resource set HOT 4
- WebExtensions.CombresLink("resourceSetName") throws System.ArgumentException and WildCard Support HOT 3
- change in files causes application pool restart HOT 1
- Update library dependencies HOT 5
- Combres can not minify AngularJs HOT 6
- Support all properties of Ajax Min
- Configs for YuiCssMinifier and YuiJSMinifier incorrect and cause exceptions HOT 1
- Custom css minifiers
- CombresHandler.ProcessRequest throwing ArgumentException with no discernible pattern. HOT 7
- dotLess strictMath mode not configurable HOT 4
- Nuget update HOT 1
- NuGet packages use strict dependency versions
- Calls to CombresLink are case sensitive - could this be changed? HOT 2
- combre 获取到的js版本内容是旧的,没有更新
- Combres does not support ECMAScript2015 HOT 1
- transpile JS via babel before minifying
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from combres.