Git Product home page Git Product logo

Comments (2)

burningalchemist avatar burningalchemist commented on May 30, 2024 1

Hi @sigurdblueface, all connection parameters are controlled via the connection string (DSN) like this (in your case):

postgres://user:pass@localhost:5432/database?sslmode=disable

Reference: https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS

If we add this parameter, then we need to pass and configure the parameter for each compatible driver. We also need to deal with ambiguity checking for passed parameters in multiple places.

It's a limitation, so the design choice here is to use DSN as we want to let users use all the available drivers and these drivers have different underlying interfaces.

For this reason we use https://github.com/xo/dburl to have a single connection mechanism for all the supported databases and eventually support more databases.

Also, most drivers nowadays have ssl feature enabled by default to encourage users protecting their database connections along with HTTPS, and this is a good practice. If we want to disable it (e.g. for localhost scenarios), it's not a big deal to check the driver and pass necessary parameters.

from sql_exporter.

sigurdblueface avatar sigurdblueface commented on May 30, 2024 1

OK. Understood, thanks.

from sql_exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.