Git Product home page Git Product logo

Comments (1)

burningalchemist avatar burningalchemist commented on May 29, 2024

Hey @alex1989hu, thanks for suggestions. Some feedback from my side:

go.mod references a minimum version of Go required by the module as per docs, so we increase it periodically. v1.16 is a valid version so far.

setup-go the way it's set in Github Actions allows me to stay up to date with a new released Go version whenever it's generally available, and to fail early if there is any issue.

In your case, I'd say there wasn't much of a problem - it wasn't a compile issue, but a part of the workflow to keep go fmt applied consistently. Apparently, go v1.19 introduced changes for go style. Moreover, those comments will go away anyway as there's another PR to refactor drivers initialization.

Since there's no automated release management for container image builds anymore (as Docker Inc. removed such an opportunity sometime ago), we know in advance what version of Go is the latest and available (via GHA) to be used during container image builds.

As sql_exporter hasn't reached v1.0, I consider this ok. We can come back to this topic later, though. :)

from sql_exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.