Add more possible Brew paths about cork HOT 25 CLOSED

from cork.

@jmb Here's your macOS 12 version with the fix implemented. I have also implemented fixes for #20 and #38, which were not a part of your original build, but I wanted to fix them for you :)
Cork.zip

Thank you this is amazing!

from cork.

Here you go:

$ brew tap-info homebrew/core
homebrew/core: 3 commands, 6540 formulae
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core (6,995 files, 557.5MB)
From: https://github.com/Homebrew/homebrew-core

from cork.

FYI... This also applies to these lines in App Constants.swift:

    static let brewCellarPath: URL = URL(string: "/opt/homebrew/Cellar")!
    static let brewCaskPath: URL = URL(string: "/opt/homebrew/Caskroom")!

Hope this helps!

from cork.

What are those two paths for you? So I know

from cork.

from cork.

@sandydunlop could you test the newest build from branch multiple-brew-paths?

@jmb, once @sandydunlop confirms that the fix is working, I will also implement it in your macOS 12 build.

from cork.

Yes, also /usr/local

from cork.

from cork.

Of course, no worries!

from cork.

Amazing, good to hear! I will merge it into main in that case.

@jmb I will update your macOS 12 build to implement this fix and then tell you when it's done

from cork.

@jmb Here's your macOS 12 version with the fix implemented. I have also implemented fixes for #20 and #38, which were not a part of your original build, but I wanted to fix them for you :)
Cork.zip

from cork.

The option for choosing your own paths is not implemented, perhaps in the future. This fix should cover all possible cases, unless the user does something batshit like moving the executable manually and not symlinking it.

from cork.

from cork.

No worries, and I thank you for your support :)

from cork.

Hey guys, could you please run brew tap-info homebrew/core and send me the output? I'm working on faster loading of Taps and I need to know where they are located for you, so this new system works for you
@jmb @sandydunlop

from cork.

@jmb could you test this build if all the tap features work?
Cork_LD.zip

@sandydunlop can you test this build, again if the taps load and the adding/removing of taps works?
Cork.zip

from cork.

It's running ok, but I'm unsure what I need to test. If I click a tap in the left menu it doesn't show me any info, if I right-click kand choose "Remove", nothing happens.

When I click Update on the main screen to update my outdated packages, it says it's pulling updates, but also doesn't seem to do anything - the list remains. It does clear when I go and look at something else and come back.

from cork.

@jmb could you try running the branch lower-deployment-target from Xcode and seeing what errors it gives?

from cork.

@jmb could you try running the branch lower-deployment-target from Xcode and seeing what errors it gives?

No major issues, the only minor error is [SwiftUI] No symbol named 'spigot' found in system symbol set.
👍🏻

from cork.

from cork.

I will try to fix that missing icon 😅 Apart from the icon, everything else works? Namely the problem with the taps and updating

from cork.

Updates all good. Taps don't seem to be left clickable - it would be handy to see the info about them. Looking at the console output in Xcode, I think it either needs to say what packages are installed that need removing first, or needs to ask if you want to remove those packages at the same time. Maybe a main panel screen with info about the tap would be helpful?

from cork.

Tap details are included in the main branch, but adding them came with a huge rewrite of the way Cork shows information, so I don't think I'll be able to backport that feature for you anymore.

I'll build the latest version of the app for you, but unfortunately, I think that will be as far as this backported version will ever go :(

from cork.

Here it is, I hope it will work:

Cork.zip

from cork.