Maintenance result alert's width too large about cork HOT 12 CLOSED

Reopening due to padding bug.

@rishatl when there's a lot of content, the top and bottom padding breaks in your implementation (which is now on the branch fixed-long-lists):

Would you mind having a look at it?

from cork.

I think I fixed the underlying problem described in #173. Could you try this branch? https://github.com/buresdv/Cork/tree/fixed-maintenance-sheet

from cork.

Hey, I'll take it upon myself, make me assignees, pls

from cork.

@buresdv, check mr👆🏻pls

from cork.

Fixed by #271

from cork.

@buresdv Removing fixedSize solved this problem

from cork.

@rishatl that does fix the padding, but now, most of the text is missing:

Also, you can expand the sheet to a ludicrous size, which looks bad 😅

I suppose the fixedSize() has to be somewhere. Do you have any other idea?

from cork.

@buresdv fixedSize() prevents the view from being expanded, and the text can be of different sizes. I think shortened text is the best solution. Otherwise you will have to bind to constant frame values, which will lead to the same situation of text moving outside the view.

from cork.

The text was supposed to be shortened, but that was causing crashes (#173). Would it be possible to shorted the text, allow the sheet to expand, but forbid it from expanding indefinitely?

from cork.

I propose this solution - a limit on the maximum size with the ability to expand only vertically if there is a lot of text.

            .frame(maxWidth: 800, maxHeight: 800)
        }
        .padding()
        .fixedSize(horizontal: true, vertical: false)

from cork.

That is definitely an interesting solution, but it still suffers from the problem of the sheet being expandable to too large of a size:

Ideally, the text that lists all the packages would expand as needed (with some sort of a layout priority), and then the rest of the sheet would be laid out. But frames in SwiftUI are a huge mystery to me, so I don't really know how to do that

from cork.

Since nobody reported any issues, I merged the fix into main (54c9ee2) and will consider this bug fixed by it

from cork.