Comments (2)
I've changed call_name(quote(foo::bar))
to return NULL
instead of failing. This way it still composes well with is_call()
: if input is a call, call_name()
and call_ns()
never fail, but might return NULL
with complex calls for which is_call_simple()
is FALSE
.
This still leaves this error:
check_and_clean_input(d1 = base::acosh, spec_names = "acosh")
#> Error in `if (is_call(x) && !(call_name(x) %in% c("::", ":::"))) ...`:
#> missing value where TRUE/FALSE needed
I think you can change your check to is_call(x) && is_simple_call(x)
. Even with CRAN rlang your current check would fail in case of complex calls like foo()()
or foo$bar()
.
from catchr.
Hello. The .subclass
argument of abort()
, warn()
and inform()
has been renamed to class
in rlang 0.4.2 (released in November 2019).
No rush but could you please look into renaming any occurrences of .subclass
in your package?
from catchr.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from catchr.