Comments (5)
@jeroenmeulenaar Do you mind upgrading to:
python --version
Python 3.6.3
As I could not reproduce this on 3.6.3
. And all tests are passing as well with this import statement as you can see here:
Line 5 in 3ba4987
So, if this has to do with python 3.4.2, then we must either increase the minimum required python version, or find out why it doesn't work on that version.
from sdk_python.
@OGKevin I'd like not to upgrade, as I like to stay on Debian stable.
I think I can workaround this by changing the offending import
Line 2 in 3ba4987
to
from simplejson import JSONDecodeError
I don't know enough about the differences between json
and simplejson
to know if this is okay...
I also run into a new issue: #73. If it's really needed I can look into upgrading python, but I'd like to understand it first...
from sdk_python.
@jeroenmeulenaar I could reproduce this indeed on python 3.4.2
I have a felling that to solve this we would need to restructure a majority of the project 🤦♂️.
So we have 2 options, increase the minimum required python version or see if we can make it backward compatible.
I think if we dive into the change logs of python we could find out why it works on 3.6
and not on 3.4
.
Cant you use pyenv on debian stable ?
from sdk_python.
@OGKevin Here is the original python issue: https://bugs.python.org/issue19361, from https://docs.python.org/3/whatsnew/3.5.html.
I think it could it be solved by changing
Line 254 in 3ba4987
to
except ValueError
, since JSONDecodeError
is a subclass of ValueError
. It doesn't look like you use the added functionality of JSONDecodeError
anyway :)
And yes, I could workaround it (pyenv, or making my own fork), but maybe others hit this issue as well. Debian stable is not very up-to-date, but it's very stable :)
from sdk_python.
@jeroenmeulenaar I see, do you mind making a PR if you think you have fixed it ? If not ill look into it, but that will take some time I have a lot on my list ATM. We will include it in the 0.13.0
release
from sdk_python.
Related Issues (20)
- The CHANGELOG is out of date HOT 1
- cannot import name 'ApiContext' from 'bunq.sdk.context' HOT 5
- AttributeError: 'SessionServer' object has no attribute '_user_payment_service_provider' HOT 1
- Complete OAuth/PSD2 implementation HOT 1
- ScheduledPaymentBatch is not in endpoint nor object
- Update tests with Type Hints (and other small Type Hint improvements)
- Is this repository even maintained? HOT 2
- Breaking changes since v1.13.0
- TreeProgress response not correctly parsed HOT 1
- Add a test for oauth_authorization_uri HOT 1
- ApiContext.create with all_permitted_ip=["ipv4"] raises BadRequestException: HTTP Response Code: 400 /w Error message: User credentials are incorrect. Incorrect API key or IP address.
- Adding additional_transaction_information to the Event object
- Remove __get_user_object call immediately after UserContext creation (reduce rate-limit hits)
- Replace /sandbox-user with /sandbox-user-person and /sandbox-user-company
- KeyError 'Id' in _unwrap_response_single (creating callbacks) HOT 1
- Lots of warnings when using the library HOT 1
- Examples are not up to date HOT 2
- Feature request: async support (with aiohttp)
- No wheels for releases newer than 0.13
- Get list of ALL payments HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk_python.