Please disable <CR> mapping when completion menu is visible (pumvisible) about bullets.vim HOT 7 CLOSED

Ok, actually after trying it with gvim -u NONE -U NONE, it seems that pressing <CR> in completion menu does insert a newline.

I'm using the mappings from http://vim.wikia.com/wiki/Improve_completion_popup_menu , esp. inoremap <expr> <CR> pumvisible() ? "\<C-y>" : "\<CR>"

I'm using Windows btw so pressing Enter to choose a completion item is the standard shortcut. But it is a bit hard to add the behaviour I want to the mapping set by the plugin, since the mapping is added by an autocommand thus it is hard to override it.

from bullets.vim.

Hi @char101,

Thanks for reaching out.

Can you please provide a minimal vimrc for reproducing the problem you are experiencing?

Are you using some plugin or special mappings for navigating and selecting a completion result?

I just tested what happens when a completion menu comes up at the end of the line and seems like <CR> should work just fine. (I am using deoplete). See GIF below:

from bullets.vim.

Hi,

From the GIF, when selecting hello_ary and pressing <CR>, it should only insert the completion without adding a newline, otherwise if I am selecting a completion mid sentence, I will have to press backspace to go back to the previous line.

from bullets.vim.

Seems like this is a setup specific to your .vimrc so I'm closing this issue.

If you want to open a PR that will set the mapping in any other way that is more easily override-able I'll be open to that.

from bullets.vim.

I just noticed this issue myself, also on Windows if that matters.

I have
let g:bullets_enabled_file_types = [ \ 'markdown', \ 'text', \ 'gitcommit', \ 'scratch' \]

and when I type some stuff in a text file to trigger the omnicompletion popup, hitting enter fails to insert the selected item from the popup. When i removed the plugin the problem went away.

Maybe changing this line:
call s:add_local_mapping('inoremap', '<cr>', '<C-]><C-R>=<SID>insert_new_bullet()<cr>')
...to this (untested) could fix it?:
call s:add_local_mapping('inoremap', '<cr>', 'pumvisible() ? "<cr>" : "<C-]><C-R>=<SID>insert_new_bullet()<cr>"')

from bullets.vim.

@FocusedWolf I don't think this will work in the first scenario in my gif above. Can you produce a minimal .vimrc that I can use to reproduce the issue and come up with a better solution?

Example minimal vimrc

syntax on
call plug#begin('~/.vim/bundle')

Plug 'dkarter/bullets.vim'
Plug 'some-other/plugin'

call plug#end()

Save it to a file and then nvim -u .debug-vimrc test.md to make sure you can still generate the error.

from bullets.vim.

I am having the same issue. The issue is that both Coc and Bullets.vim use <CR> in insert mode.

call plug#begin(stdpath('data') . '/plugged')
  Plug 'neoclide/coc.nvim', 
  Plug 'dkarter/bullets.vim',
call plug#end()

filetype plugin indent on
syntax enable

" Use <cr> to confirm completion, `<C-g>u` means break undo chain at current
" position. Coc only does snippet and additional edit on confirm.
" <cr> could be remapped by other vim plugin, try `:verbose imap <CR>`.
if exists('*complete_info')
  inoremap <expr> <cr> complete_info()["selected"] != "-1" ? "\<C-y>" : "\<C-g>u\<CR>"
else
  inoremap <expr> <cr> pumvisible() ? "\<C-y>" : "\<C-g>u\<CR>"
endif

As @FocusedWolf commented, I can see a pumvisible check like call s:add_local_mapping('inoremap', '<cr>', 'pumvisible() ? "<cr>" : "<C-]><C-R>=<SID>insert_new_bullet()<cr>"') to work , though I could not get this exact code to work.

Changing this behavior completely may not be preferred for everyone, but I would appreciate if you could set up a parameter to enable the pumvisible check. If that's not possible, a param to disable only the <CR> mapping would be pretty helpful.

Thank you.

from bullets.vim.