Artifact pull jobs say "SUCCESS" even when no artifact was fetched about bst-staging HOT 7 CLOSED

In GitLab by [Gitlab user @juergbi] on Jul 19, 2017, 07:12

assigned to [Gitlab user @juergbi]

from bst-staging.

In GitLab by [Gitlab user @tristanvb] on Jul 19, 2017, 09:31

Not sure if it makes sense to flat out assign this to [Gitlab user @juergbi] ... anyway leaving as is for the moment...

The problems here are:

• Plugin.timed_activity() assumes that any activity is either going to succeed or fail
• The outer activity timer in the scheduler (job.py) does not have a way of knowing if a job is a succeed or fail kind of job either

So, we would have to fix both of these for more comprehensive output for the kind of task which only might have some effect.

First we'd need some parameter to timed activity to change the success message to something else (and we would have to know what that something else is going to be... green "OK" ? or what ?)

Then we'd have to mark the specific scheduler Queue with some attribute to inform the scheduler what kind of timed activity flavor to use.

from bst-staging.

In GitLab by [Gitlab user @juergbi] on Jul 19, 2017, 10:03

With my OSTree summary file branch, pull jobs are scheduled only when BuildStream knows that the remote artifact repository already has that artifact. I.e., the 'not found' case should not occur anymore. And as the build plan in my branch is constructed based on the summary file, pull errors can no longer be ignored.

from bst-staging.

In GitLab by [Gitlab user @tristanvb] on Jul 19, 2017, 10:30

[Gitlab user @juergbi] Good that we can just avoid this !

But I wonder how this plays out for:

• User who has artifact cache configured
• Is currently performing an offline build

from bst-staging.

In GitLab by [Gitlab user @juergbi] on Jul 19, 2017, 10:35

If fetching the summary file fails, we could switch to offline mode instead of bailing out.

from bst-staging.

In GitLab by [Gitlab user @juergbi] on Jul 20, 2017, 07:15

mentioned in merge request !59

from bst-staging.

In GitLab by [Gitlab user @tristanvb] on Jul 20, 2017, 10:28

closed via merge request !59

from bst-staging.