Comments (6)
Things to be wary of:
- on secure systems, /tmp may have execute rights disabled, meaning any scripts copied there can't be run.
- I would suggest that the location should be configurable, and/or pulled from TMPDIR env variable.
- Use safe tempfile creation to avoid security issues raised by clobbering symlinks.
from agent.
I was gonna use this: http://golang.org/pkg/os/#TempDir Which I think handles all that for you automatically.
from agent.
I've been thinking about this, and I don't think I want to do it. The only reason is, I like the idea of being about to do a: ps aux | grep bootstrap.sh
to see if the script is running and it's location. What do you think @tarragon? Do you think this is worth changing?
from agent.
Using a ps like that won't be reliable, for instance if you are using a system and running multiple buildbox agents in docker or running multiple agents on the same box. That said to get the result you want you could use a temporary directory instead, perhaps under the buildbox path, and copy the bootstrap.sh file there instead using it's original name.
from agent.
Never "ps | grep" anyway, always "pgrep" - Your friendly neighbourhood neckbeard
from agent.
I'm going to close this. If it crops up and starts being an issue, perhaps I can add a config option for it 🍂
from agent.
Related Issues (20)
- auto release lock on failure HOT 3
- Ability to upload and download artefacts from different pipelines HOT 3
- Git Mirroring doesn't respect `BUILDKITE_REFSPEC` HOT 1
- Agent Parsing doesn't allow parameterized keys after v3.44.0 HOT 3
- Bug: Windows install script missing default value for $version HOT 1
- Buildkite build script is broken HOT 2
- Use of `FETCH_HEAD` is unreliable in conjunction with multiple refspecs in `BUILDKITE_REFSPEC` HOT 1
- Show how many jobs ahead of job in queue HOT 1
- Control the order of annotations HOT 1
- Buildkite agent for MacOS errors out on extraction HOT 2
- Haloo HOT 1
- Adding custom attributes to traces at step runtime HOT 2
- buildkite-agent annotate command should redact secrets HOT 1
- Support matrix values in step keys and concurrency groups HOT 1
- `Checkout failed!` retry times appear miscalculated HOT 1
- Print a checksum of the artifact when uploading and downloading it HOT 3
- hooks failed to run because it was already open (on `NixOS`)
- Signed Pipelines fail to verify when using interpolated environment variables HOT 3
- Race condition with socket on startup of kubernetes agent HOT 1
- Newer versions don't respect `BUILDKITE_CANCEL_GRACE_PERIOD` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from agent.