Comments (2)
So rate limiting is described in https://developer.github.com/v3/#rate-limiting. 5000 requests per hour seems reasonable. Also, an interesting way to save requests is to use conditional requests, described in https://developer.github.com/v3/#conditional-requests. Right now, Buildasaur is stateless, it pulls all data again from both Xcode Server and GitHub. Let's look into creating a small local cache so that when we get 304 Unmodified, we can pull the response from it. Also, conditional request cache hit on GitHub doesn't count towards the rate limit, so this might be the way to be able to shorten Builda's turnaround time even further below 15 seconds.
from buildasaur.
I added a basic log for every GitHub response, but that's clogging the log quite a bit. So let's add that information to the GitHub server class itself, it will keep the latest rate limit information, so that the syncer can ask for it when it's preparing the report for the UI (also, the advantage is that the latest response will be taken). Honestly, I can't be bothered to add the local request caching and do all the work to support conditional requests yet, so let's surface the rate limit in the UI and see if anyone actually ends up hitting it in practice.
So two outstanding tasks:
- add latest response's rate limit info to
GitHubServer
- add that information to the syncer's report for the UI
from buildasaur.
Related Issues (20)
- An error always appears when editing a template HOT 17
- Add Quit option to Buildasaur menu HOT 1
- Add predefined triggers HOT 1
- Trying to sync again... HOT 4
- I'm looking for a new owner for Buildasaur HOT 10
- Environment Variables? HOT 2
- Custom post-integration actions HOT 3
- Setup questions? HOT 3
- Buildasaur hangs on Build Template View when using with Xcode 8 HOT 12
- Migrate Buildasaur and deps to Swift 3
- Pattern matching for Bot branches HOT 2
- Buildasaur bots failing to find derived data
- Last Sync Failed with error (BuildaUtils.JSONError error 0) HOT 2
- Continuously happening authorization error after a while of running HOT 3
- Downloading iOS 9.3 Simulator does not proceed ahead from Xcode 8.1 HOT 1
- "Error Disallowed checkout type, the project must be checked out over one of the supported schemes: SSH" - but project *is* checked out over SSH
- XcodeServerSDK.XcodeServer.PlaceholderError error 0 HOT 1
- Unable to start app after upgrading to MacOS High Sierra HOT 6
- Announcing Xcode-GitHub, a New Buildasaur-like macOS App
- Is this going to be updated to support xcode 10 or later? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buildasaur.