Check if supplied GitHub account has read and write access to the repository about buildasaur HOT 6 CLOSED

Good point, right now Builda verifies access to the repository just by trying to read Pull Requests, which probably succeeded in your case. I guess I could try all the rights needed, by trying to create/delete a commit status and adding/deleting a comment on a PR. Or maybe there's a GitHub API call to verify rights of a token?

from buildasaur.

A few tests with the repos GET endpoint make me confident that the part with permissions is the key here. push (write) and pull (read) must be true in order to do everything Buildasaur does. Of course the requests need to be done with the token to reflect the permissions of the user which the token belongs to (but Buildasaur does that anyway).

"permissions": {
      "admin": false,
      "push": true,
      "pull": true
    }

from buildasaur.

@mdio 👍 Yeah that's it exactly. Feel free to send a pull request with the change if you want, it'd mean adding a method to GitHubServer called getRepository, creating a new entity Repository and then just changing the verification call in checkAvailabilityOfGitHubWithCurrentSettingsOfProject to use the permissions metadata to return whether Buildasaur has all the rights required. If not I'll tackle it in the next couple of days.

Thanks for taking the time to look up the API call!

from buildasaur.

I'm afraid that I won't be able to implement that today and due to tomorrow being a public holiday I won't start before monday.
Also I'm just learning Swift but thanks to your detailed idea it looks doable.

from buildasaur.

No problem, I'll take a look at it over the weekend.

from buildasaur.

Fixed in 6642a08. Let me know if this works for you, @mdio!

from buildasaur.