Comments (2)
It seems there are a few different places which the callback
argument can be invoked.
It's possible for the function to be invoked without any arguments when the Bugsnag.shouldNotify
function returns false, canceling the event from being sent to Bugsnag. See https://github.com/bugsnag/bugsnag-node/blob/master/lib/bugsnag.js#L94.
Other references are:
- https://github.com/bugsnag/bugsnag-node/blob/master/lib/notification.js#L170
- https://github.com/bugsnag/bugsnag-node/blob/master/lib/notification.js#L177
- https://github.com/bugsnag/bugsnag-node/blob/master/lib/notification.js#L179
However in the process of tracking these references, I believe I have found a condition where the callback is not invoked at all. Which is where the library invokes the beforeNotify
callbacks and allows them to prevent the event from being sent to Bugsnag. See https://github.com/bugsnag/bugsnag-node/blob/master/lib/notification.js#L123.
@kattrali what are your thoughts on this? I would expect both https://github.com/bugsnag/bugsnag-node/blob/master/lib/bugsnag.js#L94 and https://github.com/bugsnag/bugsnag-node/blob/master/lib/notification.js#L123 to invoke the callback with an error as the first argument - as they both stop the event from being sent to Bugsnag.
I'm happy to submit a PR to fix these inconsistencies, and make a small alteration to the docs to explain this situation, if you'd like?
from bugsnag-node.
Thank you for the report, @TylerBrock, and for the code dive, @jacobmarshall. I'll follow up with some feedback on #80.
from bugsnag-node.
Related Issues (20)
- Can't disable logs HOT 3
- Duplicate Error Messages in Logs HOT 1
- Cannot find module backo HOT 2
- Missing functionality or documentation for app type feature HOT 1
- No way to filter authorization header HOT 1
- Middleware crashes with serverless-http HOT 2
- Interface ConfigurationOptions is missing newer Bugsnag options HOT 4
- Source map support HOT 2
- Bugsnag: Error: uv_signal_start EINVAL HOT 9
- not able to minify using create-react-app webpack configuration HOT 7
- Express middleware not sending request details HOT 6
- bugsnag-node depends on "unlicensed" code HOT 2
- Please upgrade `request` dependency to ^2.87.0 HOT 2
- Dependency Bloat HOT 2
- Cannot read property 'startSession' of undefined on test environment HOT 2
- Sessions tracking against `production`, not configured releaseStage HOT 3
- Delivering exception to http://undefined:80undefined HOT 3
- How to add bugsnag middleware to apollo-server-lambda HOT 1
- Sending Strings to bugsnag.notify('String') are ignored HOT 2
- Bugsnag: Encountered an uncaught error, terminating. All uncaught errors force process.exit(), bad. HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bugsnag-node.