Fix redundant exception handling about bugsnag-java HOT 5 OPEN

Yes - I think it's achievable. I've raised it in our system to have a look at when priorities allow.

from bugsnag-java.

@nkavian - in your change, I believe the tests fail because Spring's DefaultHandlerExceptionResolver handles the error and so it would not make it to Bugsnag as the lowest priority handler.

In order to allow ControllerAdvice beans to swallow exceptions before the Bugsnag handler and also to catch exceptions thrown by these beans, it looks like we could make the BugsnagMvcExceptionHandler a ControllerAdvice bean with the lowest priority. (A helpful explanation of the mechanism is here.)

However, I believe this would only work for Spring MVC, and I'm not sure we could find a solution that would not risk the handler not firing for different use cases. Therefore you may wish to consider such an approach using a fork of this repo, but I believe we'd need a more general purpose approach to change the library itself.

from bugsnag-java.

Great link that's very detailed. Regarding your last paragraph, this issue is specific to Spring MVC and the suggested code change is to code within the bugsnag-spring folder, so there are no other use cases to be concerned with right?

from bugsnag-java.

The ControllerAdvice is relevant to a Spring web application but not to a Spring console application, for example.

from bugsnag-java.

I might have missed the nuance there, but that sounds like a good thing. This change would be to the Bugsnag MVC exception handler dealing with the Spring MVC.

https://github.com/nkavian/bugsnag-java/blob/master/bugsnag-spring/src/main/java/com/bugsnag/BugsnagMvcExceptionHandler.java#L22

from bugsnag-java.