Comments (2)
Hey @jgreen210,
Thanks for the suggestion.
A couple of points regarding the current implementation:
If isStarted
returns true
then getClient
will not throw an exception, which is expected.
It is allowed to return false
while start is in-flight.
Adding the lock would require isStarted to wait while start completes before returning, which is not always desirable. So is not something we would want to do.
from bugsnag-android.
Adding the lock would require isStarted to wait while start completes before returning, which is not always desirable. So is not something we would want to do.
OK, but there is still a bug here. If you don't want to obtain the lock in isStarted, then could use an AtomicBoolean to ensure there's a memory barrier. It might also be possible to fix it some other way when fix #1731 (comment)
from bugsnag-android.
Related Issues (20)
- Error Android in react-native Unexpected number of manifest paths.[] HOT 1
- StrictMode listener should log all available information HOT 2
- Add security patch level to metadata? HOT 1
- Support blocking notify HOT 4
- Crash Report HOT 2
- app que aparecieron en mi disposotivo HOT 1
- solicitud de extracion HOT 1
- Bugsnag Android Plugin crashes the app with SIGSEGV - Segmentation violation (invalid memory reference) HOT 4
- Invalid grouping of native crashes coming from a dynamic library HOT 6
- Bugsnag does not report All types of metadata for native crashes HOT 2
- String metadata is being trimmed to 63 characters (native crashes) HOT 1
- Timeout uploading mappings to bugsnag HOT 3
- ANR com.bugsnag.android.DataCollectionModule.getDeviceDataCollector HOT 2
- Help needed contributing HOT 1
- Gradle sync issues on applying com.bugsnag.android.gradle plugin HOT 2
- Why did you make DefaultDelivery as internal ? HOT 3
- Add ability to override/mock the Client HOT 7
- ANR in Bugsnag.start (ForegroundDetector.getProcessInfo) HOT 14
- ActivityBreadcrumbCollector surfaces the wrong activity previous state HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bugsnag-android.