Git Product home page Git Product logo

Comments (8)

adrianheine avatar adrianheine commented on June 20, 2024

@Rich-Harris what do you think? Since IE11 doesn't support classes, #66 and #40 are relevant here, too. I would say bublé should only be compiled for node 4.

from buble.

Andarist avatar Andarist commented on June 20, 2024

Maybe you could transpile with node4 support in mind for main entry and for the browser it could be transpiled down to es5? Although Im not sure what to do about module entry - at the moment its mainly targeting browsers too (as its understood by bundlers), but maybe some people somehow bundle for node too? 🤔 Would be actually good to have browser:module/module:browser 😂

from buble.

Andarist avatar Andarist commented on June 20, 2024

@adrianheine WDYT about the proposed solution of transpiling with different targets in mind for main and browser fields?

from buble.

adrianheine avatar adrianheine commented on June 20, 2024

I think that makes sense. We would have to find a workaround for #40, though.

from buble.

Andarist avatar Andarist commented on June 20, 2024

Imho that's a separate issue, that could ofc be fixed/tackled somehow but it is not tightly coupled to this one - or am I missing something?

from buble.

adrianheine avatar adrianheine commented on June 20, 2024

It is coupled, because transpiling classes will make our errors not have a message or a stack, so we would basically break the browser build.

from buble.

Andarist avatar Andarist commented on June 20, 2024

Hm, I can't be sure about all old browser, but you assign custom stack property here and it is readable in latest Chrome (when using transpiled version of CompileError class). Ain't sure about description because I don't know origin of this property - you do not specify it in CompileError's constructor nor it is built-in property of native Error. Maybe you had some other prop in mind?

most.js has migrated to transpiled version of buble's output (because they have migrated to babel which didnt support extending built-ins) for their custom DisposeAllError and it seems to work OK.

from buble.

adrianheine avatar adrianheine commented on June 20, 2024

Sorry, I meant message. It seems like you're right and CompileError already does what's necessary, so we should be able to do this.

from buble.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.