[BTRACE-38] As a BTrace user I would like to be able build up complex strings with a StringBuffer inside the BTrace Scripts about btrace HOT 6 CLOSED

[author="jbachorik", created="Mon, 17 May 2010 13:29:18 +0200"]

The intended functionality sounds reasonable.

Anyway, I have few comments for the patch:

1. Consider renaming newStringBuffer() method to newStringBuilder(boolean threadSafe) - giving the API caller the option to create either StringBuilder(thread-unsafe) or StringBuffer (thread-safe)
2. Consider dropping the specialized versions of the "append" method, keeping only the "append(StringBuffer buffer, String strToAppend)" version. The specialized versions can be replaced by calling "append(buffer, str(nonString))" - otherwise you would need to wrap pretty large portion of the "append" methods from the backing StringBuilder/Buffer

from btrace.

[author="joachimhskeie", created="Tue, 18 May 2010 20:32:46 +0200"]

The problem here then, is that both StringBuffer and StringBuilder extends java.lang.Object, and the BTrace Script needs to declare the type of the Builder/Buffer (to avoid having to work with Object).

I guess its possible to do one of two things:

#. Add both a newStringBuffer() and newStringBuilder() methods, and both append(StringBuffer, String) append(StringBuilder, String).
#. Create a BtraceStringBuffer that will either keep one StringBuilder or one StringBuffer.

I'd chose the first option, though, that makes the code slightly cleaner and lighter.

from btrace.

[author="joachimhskeie", created="Thu, 17 Jun 2010 12:40:48 +0200"]

Jaroslav: Are you able to comment on the two proposed solutions ?

from btrace.

[author="jbachorik", created="Thu, 24 Jun 2010 08:03:02 +0200"]

newStringBuilder()/newStringBuffer() approach seems to be the correct one

from btrace.

[author="joachimhskeie", created="Tue, 29 Jun 2010 08:04:22 +0200"]

Would it then be OK to move this issue to the 1.2 release and commit the patch for the StringBuffer while at the same time opeing a new issue to implement the newStringBuilder() methods ?

from btrace.

[author="jbachorik", created="Fri, 9 Jul 2010 16:21:38 +0200"]

I've adapted your proposed patch to use java.lang.Appendable instead of StringBuffer/StringBuilder, thus having only one set of methods for working with appendable buffers.

Fixed http://kenai.com/projects/btrace/sources/hg/revision/325

from btrace.