[BTRACE-45] Print multiple aggregations in one printAggregation() command about btrace HOT 8 CLOSED

[author="joachimhskeie", created="Wed, 4 Aug 2010 15:42:10 +0200"]

I am unable to make the BTrace compiler accept the varargs parameters like:

printAggregation(String stringFormat, Aggregation ... aggregationArray)

I am able to make this work with a single Aggregation, but with multiple aggregations the BTrace Compiler states that only methods for BTraceUtils might be used.

Is this a shortcoming of the BTrace Compiler class ?

from btrace.

[author="joachimhskeie", created="Thu, 5 Aug 2010 22:37:44 +0200"]

I found the culprit in the VerifierVisitor class. I added a bit of code that makes the compiler compile the class when the method in BTraceUtils is a varargs method. However, this would need some type checking.

Actually, looking at the code, I would assume it safer if all parameter types were checked, and not just a check to see if the method invoked has the same amount of parameters

from btrace.

[author="joachimhskeie", created="Thu, 5 Aug 2010 23:37:34 +0200"]

I was unable to the the varargs method to work at all (the JVM translates the varargs arguments to an Array, which causes the Verifier to think that the BTrace Script is creating a new Array.

I have instead opted to implement this functionality using the Collections that were available in BTraceUtils already.

I think this is a better option than the CountingAverage approach as this makes it possible to combine any Aggregation, as long as it has the same AggregationKey.

I am attaching a diff new diff file which implements this functionality as well.

I am using the Aggregation in a script as follows:

    @OnTimer(7500)
    public static void printAverage() {
        Deque aggregationDeque = newDeque();
        addLast(aggregationDeque, AVERAGE);
        addLast(aggregationDeque, CALLS_PER_INTERVAL);
    <span class="code-object">String</span> execStringFormat = strcat(<span class="code-quote">"[AverageExecTime;"</span>, property(<span class="code-quote">"btrace.agentname"</span>));
    Aggregations.printAggregation(<span class="code-quote">"", strcat(execStringFormat, "</span>;%1$s;%2$s;%3$d;%4$s;%5$s;%6$s;Custom]"), aggregationDeque);
    
    truncateAggregation(AVERAGE, 0);
    truncateAggregation(CALLS_PER_INTERVAL, 0);
}   

[author="jbachorik", created="Mon, 9 Aug 2010 11:01:15 +0200"]

The enhanced version of printAggregation() method sounds good.

Go ahead and push the changes. Please, make sure all the newly added public methods are properly documented and don't forget to add the @SInCE tag (for version 1.2)

from btrace.

[author="jbachorik", created="Fri, 13 Aug 2010 09:54:35 +0200"]

Will you be able to push the changes soon? If not I might apply the changes for you.
I want to start preparations for 1.2 release and I need to have all issues targeted for 1.2 resolved.

from btrace.

[author="joachimhskeie", created="Fri, 13 Aug 2010 10:30:45 +0200"]

I will push the changes over the weekend.

from btrace.

[author="joachimhskeie", created="Mon, 23 Aug 2010 22:33:54 +0200"]

Sorry for the late push! I have pushed the changes now. I chose not to push the CountingAverage Aggregation, as its probably redundant with the ability to combine aggregations into a single print.

from btrace.

[author="joachimhskeie", created="Mon, 23 Aug 2010 22:34:27 +0200"]

Changing Fix Version to 1.2 as per comments from JB.

from btrace.