[BTRACE-77] Inner Classes Check breaks Profiling example / inner classes check is too strict about btrace HOT 3 CLOSED

[author="j.bachorik", created="Tue, 11 Oct 2011 21:16:04 +0200"]

Did you try it with the unmodified sample script? When I try run the Profiling.java sample everything works as expected.

Also, it is rather suspicious an innerclass is visited - there are no inner classes in the sample and if an erroneous bytecode should be caused by a syntax error the standard java compiler, which btrace does use, would encounter the problem and throw an exception.

Can you attach the sample source you are using?

Thanks.

from btrace.

[author="mjakl", created="Wed, 12 Oct 2011 10:26:20 +0200"]

Hi, I've attached the Samplecode (it should be the unmodified version of the Profiling example).

On my machine this still leads to this:

mjakl@T510:BTrace % bin/btrace 2514 Profiling.java
com.sun.btrace.VerifierException: nested and inner classes are not allowed
at com.sun.btrace.runtime.Verifier.reportError(Verifier.java:390)
at com.sun.btrace.runtime.Verifier.reportError(Verifier.java:381)
at com.sun.btrace.runtime.Verifier.visitInnerClass(Verifier.java:155)
at com.sun.btrace.org.objectweb.asm.ClassReader.accept(Unknown Source)
at com.sun.btrace.org.objectweb.asm.ClassReader.accept(Unknown Source)
at com.sun.btrace.runtime.InstrumentUtils.accept(InstrumentUtils.java:66)
at com.sun.btrace.runtime.InstrumentUtils.accept(InstrumentUtils.java:62)
at com.sun.btrace.agent.Client.verify(Client.java:391)
at com.sun.btrace.agent.Client.loadClass(Client.java:218)
at com.sun.btrace.agent.RemoteClient.(RemoteClient.java:59)
at com.sun.btrace.agent.Main.startServer(Main.java:379)
at com.sun.btrace.agent.Main.access$000(Main.java:65)
at com.sun.btrace.agent.Main$3.run(Main.java:166)
at java.lang.Thread.run(Thread.java:662)

There is in fact a hidden inner class. It's only used, not embedded in the sample script itself. In line 21 we use BTraceUtils.Profiling.newProfiler(), Profiling is the inner class of BTraceUtils.

HTH,
Michael

from btrace.

[author="j.bachorik", created="Tue, 18 Oct 2011 12:24:30 +0200"]

fixed
http://kenai.com/projects/btrace/sources/hg/revision/434

from btrace.