Write tests about pre-require HOT 9 CLOSED

@gatukgl yes I think you should initilize your own assets.js file before starting your test. Like you can have a test asset folder;

test-assets/
 - asset1.png
 - asset2.png
 - ...

Thank you can initilize the node index test-assets/ assets.js

Then you can use the assets.js file that you generated for your tests.

from pre-require.

I just have an idea to separate both search() and format() in index.js to be real functions (not just a plain text) so we can easily write unit tests. Would you mind if I open a new issue to refactor that two? :D

So it will looks like below.

   // index.js
    ...

    let assetsFileContent = `// import this file for static assets
    let Obj = {
      ${slugArray.join(', ')},
      search: ${searchFile},
      format: ${searchFileFormat}
    }
    export default Obj;
    `;

   ...

const searchFile = function(key) {
  if(this.hasOwnProperty(key)) {
    return this[key];
  } else {
    return -1;
  }
}

const searchFileFormat = function(extension) {
  let filteredArray = this.filter(assetSlug => (assetSlug.includes("-"+extention)));
    if(filteredArray.length){
       return filteredArray;
    } else {
       return -1;
    }
}

from pre-require.

I'm working on it. 🎉

from pre-require.

@gatukgl that's great, if you have any question with the usage cases you can ask in this issue.

from pre-require.

@btk I wonder, to test .format and .search function. Is that ok to test on assets.js file?

from pre-require.

@gatukgl yeah, that is actually really smart!

How do you plan to get them functions into text so the generated file will be as intended? Your current code, (I'm not sure but) ${searchFile} won't work? Maybe you can use something like function.prototype.toString()

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/toString

If you can manage the "real" functions to be printed in the assets.js as intended, I would love to see your pr. Thank you.

from pre-require.

Great!! I’ll try :) Thank you.

from pre-require.

@btk I've already opened PR to test .search() and I'm just curious, for the .filter() in .format(), does it work with an object?

from pre-require.

Handled by #31

We might have a new issue to list other possible test cases to be implemented in future. Thank you.

from pre-require.