Proposal to deprecate old and redundant APIs about btcjson HOT 2 CLOSED

I personally would prefer to go further than deprecating them and remove them outright. You've made a great summary of why this needs to happen.

The only questionable one is JSONToNumber since I believe it has some extra range checks that should happen before converting to an int that btcutil.Amount does not do.

I fully agree with the rest however.

from btcjson.

JSONToAmount checks that the floating point value being converted is no greater than 1.797693134862315708145274237317043567981e+300 and no less than -1.797693134862315708145274237317043567981e+300. It does not perform any checking that the returned int64 is within the total amount of bitcoin producable.

If that check is desired, I can add a function to check that to btcutil, but since that's an application specific requirement (for example, an Amount returned by getreceivedbyaddress may exceed 21e6 * 1e8) I don't think checking that from NewAmount is a good idea. In fact, it used to, but I removed that additonal bounds check for this very reason.

from btcjson.