Git Product home page Git Product logo

Comments (8)

F21 avatar F21 commented on June 28, 2024

Before I start on this, what do you think about implementing the plugin architecture as mentioned earlier before doing this?

from oauth2-server-php.

bshaffer avatar bshaffer commented on June 28, 2024

I don't think it will be happening any time soon. Code away!

from oauth2-server-php.

bshaffer avatar bshaffer commented on June 28, 2024

One thing I wouldn't mind seeing is an interface for the ExtensionGrantType, so JWT and any other types can extend those.

from oauth2-server-php.

F21 avatar F21 commented on June 28, 2024

@bshaffer Just revisiting this (its been a while!).

Latest spec for JWT is here.

For JWT client authentication, it is basically piggy backing on the authorization_code grant type. So we can either put the code for that into the AuthorizationCode grant type or perhaps provide some modular approach.

I personally favour a more modular approach, but am unsure how this can be done. Any ideas 😄 ?

from oauth2-server-php.

bshaffer avatar bshaffer commented on June 28, 2024

Well, I DO like the word "modular" :)

As long as it implements a common interface I am cool with either approach... extending a base class or duplicating the code. Our "built in" JWT client assertion could just extend the AuthorizationCode grant type wholesale.

Honestly, I'd have to wrap my brain around the problem a little more. I will definitely look into it, and offer feedback to any code you submit!

from oauth2-server-php.

bshaffer avatar bshaffer commented on June 28, 2024

I may be missing something, but I believe this is already done. JWTBearer now implements ClientAssertionTypeInterface. This means, if we want to use it for client assertions, we just need to pass it in to the TokenController object when we create it.

There is still the issue that there is no way to pass this in to the Server class. However, if we add this, we should be good to go.

from oauth2-server-php.

F21 avatar F21 commented on June 28, 2024

@bshaffer I will have a look at it over the next few days (pretty busy atm) and get back to you 😄

from oauth2-server-php.

F21 avatar F21 commented on June 28, 2024

Thanks to @bshaffer, ClientAssertionTypeInterface is implemented, client authentication is now supported. Now, we just need to find a way to pass this to the Server.

from oauth2-server-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.