re-factor yt player lib to use AppDataStore about songhay-ng-workspace HOT 9 CLOSED

commits i forgot to associate with this issue:

• 6ddf577
• e7c8353
• c8ec39b

from songhay-ng-workspace.

as of month 5 2018 (version 2.9) Typescript can import *.json files as static modules—huge for testing: https://stackoverflow.com/questions/49996456/importing-json-file-in-typescript

from songhay-ng-workspace.

wow, this is yet another discovery for me (injecting the injector):

/**
 * Creates an instance of @type {YouTubeChannelDataStore}.
 * @param {Injector} injector
 * @memberof YouTubeChannelDataStore
 */
constructor(injector: Injector) {
    super(
        injector.get<HttpClient>(HttpClient),
        YouTubeChannelDataStore.getOptions()
    );
}

from songhay-ng-workspace.

let me try to catch up with myself:

• i have learned that bare naked JSON files can be treated as modules by TypeScript 2.9+ 👍
• i have re-factored AppDataStore to get AppDataStoreOptions via an override instead of DI
• services over HttpClient should have tests that look like this:

it renders clear that these observable data service tests are concerned with:

• documenting the endpoint URIs
• getting data the expected number of times
• converting that data to models of the client domain the expected number of times

from songhay-ng-workspace.

i could close this issue with the latest commit but i should use the client project of this workspace to visualize the Angular yt Angular components 🔨 ✏️

ng generate module components/yt --flat=true --module=app --project=client --dry-run=true
ng generate component components/yt/index --flat=true --module=yt --project=client --skip-tests=true --dry-run=true
ng generate component components/yt/presentation --flat=false --module=yt --project=client --skip-tests=true --dry-run=true
ng generate component components/yt/thumbs --flat=false --module=yt --project=client --skip-tests=true --dry-run=true
ng generate component components/yt/set --flat=false --module=yt --project=client --skip-tests=true --dry-run=true

from songhay-ng-workspace.

with the last commit, i see that i am still having trouble properly accounting the endpoints of the b-roll API: none of the new services are using rxYouTubeApiPlaylistPath—and:

• you-tube-channel-data.store.getUri() should use rxYouTubeApiPlaylistPath instead of rxYouTubeApiVideosPath
• you-tube-channels-presentation-data.store should be renamed to you-tube-presentation-data.store
• you-tube-presentation-videos-data.store should be added with its getUri using rxYouTubeApiVideosPath

from songhay-ng-workspace.

testing is showing me that you-tube-channel-data.store can support domain translation for two endpoints:

• Player/v1/video/youtube/playlist/uploads/{id}
• Player/v1/video/youtube/videos/{id}

both of these are expecting json as { items: {} }; there is no need for you-tube-presentation-videos-data.store

from songhay-ng-workspace.

what is left:

• write documentation about setting up the yt lib
• deal with SVG assets and styling in a lib

from songhay-ng-workspace.

👍 however, console output in the browser reminds me of this issue: https://github.com/BryanWilhite/Songhay.Dashboard/issues/25

from songhay-ng-workspace.