Please include default settings in settings.py about django-password-reset HOT 3 CLOSED

You can subclass the views to configure the app. I agree sometimes settings can be convenient but in this case it's more noise and a level of coupling that's really not needed.

Is the case_sensitive parameter going to change between local development, staging and production? Same question with token_expires :)

My take is that while this might change between a project an another, it's not a good enough case for adding new settings.

from django-password-reset.

I agree with the original request.
IMO/E subclassing views of third-party apps should be reserved for more heavy customisation than just changing some basic configuration. Otherwise, why do we have a settings.py at all, when we could just subclass everything? And, certainly IME, the settings file is not only used for values that change between production, development, etc. environments.

Not to mention that if you subclass any of the views, you would then also have to reconstruct at least part of the URLconf, rather than just following the basic install instructions and adding one or two lines to settings.py. Seems a bit much, just to change a token expiry time?

from django-password-reset.

@raumkraut 👍

from django-password-reset.