Git Product home page Git Product logo

Comments (12)

kirillkovalenko avatar kirillkovalenko commented on August 16, 2024

Just found out that it does work with 3.2.0. So it must be a regression.

from strongnamesigner.

brutaldev avatar brutaldev commented on August 16, 2024

@kirillkovalenko Unfortuantely I cannot reproduce this:

-------------------------------------------------------------------
---- Brutal Developer .NET Assembly Strong-Name Signer 3.2.1.0 ----
-------------------------------------------------------------------
Console application to sign .NET assemblies with a strong-name key and fix assembly references.
Checking assembly references in 'C:\Users\werne\.nuget\packages\ntapidotnet\1.1.33\lib\net461\NtApiDotNet.dll'.
Signing assembly 'C:\Users\werne\.nuget\packages\ntapidotnet\1.1.33\lib\net461\NtApiDotNet.dll'.
Saving changes to assembly 'C:\Users\werne\.nuget\packages\ntapidotnet\1.1.33\lib\net461\NtApiDotNet.dll'.

from strongnamesigner.

DanAvni avatar DanAvni commented on August 16, 2024

I am having the same issue

`
------ Build started: Project: Base, Configuration: Debug x86 ------
Restoring NuGet packages...
To prevent NuGet from downloading packages during build, open the Visual Studio Options dialog, click on the Package Manager node and uncheck 'Allow NuGet to download missing packages'.
All packages listed in packages.config are already installed.

---- Brutal Developer .NET Assembly Strong-Name Signer 3.3.2.0 ----

Console application to sign .NET assemblies with a strong-name key and fix assembly references.

  1. Loading assemblies...
  2. Checking assembly references...
    Checking assembly references in 'D:\Develop\Project\packages\GeoTimeZone.5.2.0\lib\net462\GeoTimeZone.dll'.
  3. Strong-name unsigned assemblies...
  4. Fix InternalVisibleToAttribute references...
  5. Fix CustomAttributes with Type references...
  6. Cleanup...
    Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'
    at Mono.Cecil.BaseAssemblyResolver.Resolve(AssemblyNameReference name, ReaderParameters parameters)
    at Mono.Cecil.DefaultAssemblyResolver.Resolve(AssemblyNameReference name)
    at Mono.Cecil.MetadataResolver.Resolve(TypeReference type)
    at Mono.Cecil.Mixin.CheckedResolve(TypeReference self)
    at Mono.Cecil.SignatureReader.ReadCustomAttributeEnum(TypeReference enum_type)
    at Mono.Cecil.SignatureReader.ReadCustomAttributeElement(TypeReference type)
    at Mono.Cecil.SignatureReader.ReadCustomAttributeConstructorArguments(CustomAttribute attribute, Collection1 parameters) at Mono.Cecil.MetadataReader.ReadCustomAttributeSignature(CustomAttribute attribute) at Mono.Cecil.CustomAttribute.<Resolve>b__35_0(CustomAttribute attribute, MetadataReader reader) at Mono.Cecil.ModuleDefinition.Read[TItem](TItem item, Action2 read)
    at Mono.Cecil.CustomAttribute.Resolve()
    at Mono.Cecil.CustomAttribute.get_HasConstructorArguments()
    at System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext() at System.Collections.Generic.List1..ctor(IEnumerable1 collection) at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source)
    at Brutal.Dev.StrongNameSigner.SigningHelper.SignAssemblies(IEnumerable1 assemblyInputOutputPaths, String keyFilePath, String keyFilePassword, String[] probingPaths) at Brutal.Dev.StrongNameSigner.Console.Program.SignAssemblies(Options options) at Brutal.Dev.StrongNameSigner.Console.Program.Main(String[] args) D:\Develop\Project\Libraries\Base\Base.vbproj(2619,5): error MSB3073: The command ""D:\Develop\Project\packages\Brutal.Dev.StrongNameSigner.3.3.2\build\StrongNameSigner.Console.exe" -in "..\..\packages\GeoTimeZone*\*\net462"" exited with code 1.

The assembly does get signed but during cleanup something fails

from strongnamesigner.

brutaldev avatar brutaldev commented on August 16, 2024

Created a .NET 4.6.2 console app and added GeoTimeZone.5.2.0 through NuGet and used the same console app arguments to sign it without any errors. I even just added the strong name signer NuGet package and running the build signs everything (all versions).

Do you have a sample project this happens on @DanAvni ?

from strongnamesigner.

DanAvni avatar DanAvni commented on August 16, 2024

@brutaldev , when trying to create a sample project it worked so I have no idea what causes this on my solution but I did solve this by turning off the auto build and just including a call on BeforeBuild to the StrongName console to sign GeoTimeZone

from strongnamesigner.

brutaldev avatar brutaldev commented on August 16, 2024

Found this to be the new feature that fixes custom attributes and sometimes it cannot resolve the types. Added handling around that so this is fixed up in v3.3.3 - 7daf240

from strongnamesigner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.