Comments (12)
Just found out that it does work with 3.2.0. So it must be a regression.
from strongnamesigner.
@kirillkovalenko Unfortuantely I cannot reproduce this:
-------------------------------------------------------------------
---- Brutal Developer .NET Assembly Strong-Name Signer 3.2.1.0 ----
-------------------------------------------------------------------
Console application to sign .NET assemblies with a strong-name key and fix assembly references.
Checking assembly references in 'C:\Users\werne\.nuget\packages\ntapidotnet\1.1.33\lib\net461\NtApiDotNet.dll'.
Signing assembly 'C:\Users\werne\.nuget\packages\ntapidotnet\1.1.33\lib\net461\NtApiDotNet.dll'.
Saving changes to assembly 'C:\Users\werne\.nuget\packages\ntapidotnet\1.1.33\lib\net461\NtApiDotNet.dll'.
from strongnamesigner.
I am having the same issue
`
------ Build started: Project: Base, Configuration: Debug x86 ------
Restoring NuGet packages...
To prevent NuGet from downloading packages during build, open the Visual Studio Options dialog, click on the Package Manager node and uncheck 'Allow NuGet to download missing packages'.
All packages listed in packages.config are already installed.
---- Brutal Developer .NET Assembly Strong-Name Signer 3.3.2.0 ----
Console application to sign .NET assemblies with a strong-name key and fix assembly references.
- Loading assemblies...
- Checking assembly references...
Checking assembly references in 'D:\Develop\Project\packages\GeoTimeZone.5.2.0\lib\net462\GeoTimeZone.dll'. - Strong-name unsigned assemblies...
- Fix InternalVisibleToAttribute references...
- Fix CustomAttributes with Type references...
- Cleanup...
Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'
at Mono.Cecil.BaseAssemblyResolver.Resolve(AssemblyNameReference name, ReaderParameters parameters)
at Mono.Cecil.DefaultAssemblyResolver.Resolve(AssemblyNameReference name)
at Mono.Cecil.MetadataResolver.Resolve(TypeReference type)
at Mono.Cecil.Mixin.CheckedResolve(TypeReference self)
at Mono.Cecil.SignatureReader.ReadCustomAttributeEnum(TypeReference enum_type)
at Mono.Cecil.SignatureReader.ReadCustomAttributeElement(TypeReference type)
at Mono.Cecil.SignatureReader.ReadCustomAttributeConstructorArguments(CustomAttribute attribute, Collection1 parameters) at Mono.Cecil.MetadataReader.ReadCustomAttributeSignature(CustomAttribute attribute) at Mono.Cecil.CustomAttribute.<Resolve>b__35_0(CustomAttribute attribute, MetadataReader reader) at Mono.Cecil.ModuleDefinition.Read[TItem](TItem item, Action
2 read)
at Mono.Cecil.CustomAttribute.Resolve()
at Mono.Cecil.CustomAttribute.get_HasConstructorArguments()
at System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext() at System.Collections.Generic.List
1..ctor(IEnumerable1 collection) at System.Linq.Enumerable.ToList[TSource](IEnumerable
1 source)
at Brutal.Dev.StrongNameSigner.SigningHelper.SignAssemblies(IEnumerable1 assemblyInputOutputPaths, String keyFilePath, String keyFilePassword, String[] probingPaths) at Brutal.Dev.StrongNameSigner.Console.Program.SignAssemblies(Options options) at Brutal.Dev.StrongNameSigner.Console.Program.Main(String[] args) D:\Develop\Project\Libraries\Base\Base.vbproj(2619,5): error MSB3073: The command ""D:\Develop\Project\packages\Brutal.Dev.StrongNameSigner.3.3.2\build\StrongNameSigner.Console.exe" -in "..\..\packages\GeoTimeZone*\*\net462"" exited with code 1.
The assembly does get signed but during cleanup something fails
from strongnamesigner.
Created a .NET 4.6.2 console app and added GeoTimeZone.5.2.0 through NuGet and used the same console app arguments to sign it without any errors. I even just added the strong name signer NuGet package and running the build signs everything (all versions).
Do you have a sample project this happens on @DanAvni ?
from strongnamesigner.
@brutaldev , when trying to create a sample project it worked so I have no idea what causes this on my solution but I did solve this by turning off the auto build and just including a call on BeforeBuild to the StrongName console to sign GeoTimeZone
from strongnamesigner.
Found this to be the new feature that fixes custom attributes and sometimes it cannot resolve the types. Added handling around that so this is fixed up in v3.3.3 - 7daf240
from strongnamesigner.
Related Issues (20)
- It seems not working in sdk-style project with third-part packages HOT 6
- How to consume a NuGet package with signed external references? HOT 3
- Writing mixed-mode assemblies is not supported HOT 3
- Transitive dependencies from PackageReferences are not investigated/signed HOT 3
- Use NuGet package, but no automatic signing of assemblies HOT 2
- Use NuGet package, but no automatic signing of assemblies HOT 2
- Virus Detected on Chrome when downloading StrongNameSigner_Setup.exe HOT 1
- SDK style probjects supported? HOT 4
- Fixing unsigned references in signed assemblies when signing unsigned assemblies - unhandled case? HOT 5
- [Bug]: When the GUI comes across a "Unsupported PDB deleted bitset is not empty" it stops processing HOT 1
- [Feature Request]: convert the "Unsupported PDB deleted bitset is not empty" Error to a warning, so that the commandline app does not report errors HOT 2
- [Feature Request]: Can the Gui state what file has been used to sign a binary HOT 1
- [Bug]: If strongnamer is already processing a file, then do not throw an error when it tries to open it again due to parallel builds
- [Change Request]: Please change the column named `Signed` to be `StrongNamed` HOT 1
- [Feature Request]: Have a column called `DigCert` to show if this binary also has been digitally signed HOT 2
- [Bug]: Getting `Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'mscorlib, Version=4.0.0.0` for x86 project HOT 13
- Keyset does not exist error when using custom SNK generated from PFX file HOT 3
- Does not work with VS 2022 started with Admin rights targeting .net 4.8 framework HOT 9
- Can not get it to work with .NET Standard 2.0 Project and Nuget Packages Scrypt.NET and CSVTextFieldParser HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strongnamesigner.