Why not use `renderer` prop on `Tree` for NodeRenderer? about react-arborist HOT 2 CLOSED

Ok, gotcha. Yeah, I thought more about it and it seems like it's basically a variation of the render prop pattern. I didn't recognize that with the Node pulled into a external variable, rather than provided inline as a closure. Thanks for responding!

from react-arborist.

Hi @acjay, thanks for writing up this suggestion. I know what you mean. It does seem a little strange. I based that API on the react-window library, which is used by react-arborist. Brian passes in the row renderer as a single child component.

Over time, it grew on me. It mirrors the hierarchy between the parent Tree component and the children Node components.

Since React's children are just a special-case prop, I suppose you could make this argument for any component that accepts children.

Why do we write...

<Parent>
  <Child />
</Parent>

instead of...

<Parent children={<Child />} />

I admit the way we use the "children" prop in the Tree is different than above, but it's at least a bit similar.

In the end I think this is just a "chocolate" or "vanilla" type decision, so I plan to leave the API as is.

However, I thank you for your time and for prompting me to think about this more.

from react-arborist.