Comments (1)
Hi, the main issue is that your floats are casted to int
, so you're actually passing 37
and 62
, respectively. PHP does not even complain in this case, which is a pity IMO. Now because of the spread of the remainder on the first monies, you get a different result when the parameters are passed in a different order, this is expected.
Now if you want consistent results not depending on the order of the ratios, you can use allocateWithRemainder()
:
use Brick\Money\Money;
$profit = Money::ofMinor(1000, 'GBP');
[$a, $b, $r1] = $profit->allocateWithRemainder(37, 62); // 3.73, 6.26, 0.01
[$c, $d, $r2] = $profit->allocateWithRemainder(62, 37); // 6.26, 3.73, 0.01
I would consider a PR to accept non-integer ratios, by the way!
from money.
Related Issues (20)
- Adding/Subtracting Money objects, but can't Multiply/Divide HOT 2
- No support for adding CurrencyProviders HOT 12
- Laravel issue HOT 1
- Requesting a release for brick/math 0.10 compatibility HOT 3
- json serialization HOT 2
- Add a compareTo method HOT 2
- Missing a few country currencies HOT 5
- allocateWithRemainder() performs no allocation HOT 4
- Adding a `times()` alias
- what is the default value of null price? HOT 2
- Calculations without currency. HOT 1
- Allocate method not working as expected. HOT 2
- Support for lowercase currency
- Is it planned to support the distribution of funds by fractional ratios? HOT 1
- Round to nearsest HOT 3
- Feature request: Allow arithmetic operations with differing currencies if one money obj has amount of 0 HOT 1
- NumberFormatException on multiply operation HOT 2
- Unknown currency code: CNH HOT 2
- Unexpected `RoundingNecessaryException` on get integer value HOT 2
- Default Currency
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from money.