Comments (3)
BenMorel
commented on July 23, 2024
1
It's different there. MoneyBag only deals with currency codes, so getAmount() needs to accept custom (string) currency codes as well. Other methods need a Currency instance, so cannot work with custom currency codes directly.
I actually fixed the docblock in a066e30 to reflect the fact that non-ISO currency codes are acceptable there!
from money.
BenMorel
commented on July 23, 2024
Hi, this was a bug indeed, thanks for reporting it!
Fixed in 91f2b5b and released in 0.4.5.
from money.
davewwww
commented on July 23, 2024
if you fix that problem this way you also have to add your code here:
Line 182 in ee7c9c7
Line 214 in ee7c9c7
Line 240 in ee7c9c7
Line 619 in ee7c9c7
Line 56 in ee7c9c7
so maybe you move your fix directly to the Currency class:
Line 89 in ee7c9c7
from money.
Related Issues (20)
- Ability to set default context and rounding mode HOT 3
- Adding/Subtracting Money objects, but can't Multiply/Divide HOT 2
- No support for adding CurrencyProviders HOT 12
- Laravel issue HOT 1
- Requesting a release for brick/math 0.10 compatibility HOT 3
- json serialization HOT 2
- Add a compareTo method HOT 2
- Missing a few country currencies HOT 5
- allocateWithRemainder() performs no allocation HOT 4
- Adding a `times()` alias
- what is the default value of null price? HOT 2
- Calculations without currency. HOT 1
- Allocate method not working as expected. HOT 2
- Support for lowercase currency
- Is it planned to support the distribution of funds by fractional ratios? HOT 1
- Round to nearsest HOT 3
- Feature request: Allow arithmetic operations with differing currencies if one money obj has amount of 0 HOT 1
- NumberFormatException on multiply operation HOT 2
- Unknown currency code: CNH HOT 2
- Unexpected `RoundingNecessaryException` on get integer value HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from money.