Comments (8)
In CI we build with 1.61.1 as the MSRV and that build passes. Which version of Rust are you building with? Are our 1.61.1 jobs in CI doing something wrong?
from ring.
mk/cargo.sh test also generates warnings, but warnings are not treated as errors here, which they are in the main build. So maybe the CI run has overlooked the problem?
Specifically, I've seen this warning on 1.71, and having discovered that invalid_reference_casting is newly introduced (they renamed it, what were they thinking?!), wouldn't expect it to work on anything < 1.73.
I tried mk/cargo.sh test with 1.61 to confirm this warning was present in that version (it also generated some additional warnings I haven't seen before).
from ring.
Warnings confirmed in example https://github.com/briansmith/ring/actions/runs/7492345579/job/20400988301
from ring.
mk/cargo.sh test also generates warnings, but warnings are not treated as errors here, which they are in the main build.
When I do cargo +1.71.0 check
I do indeed get a warning, but it doesn't cause the build to fail.
from ring.
Sorry, should have made it clear - it's -D warnings
in our application build that's causing builds to fail. We don't really expect warnings from 3rd party crates (or our own code), and ring
did not formerly issue any.
from ring.
If there is a way to detect which rustc version will be used, that doesn't require shelling out to run rustc
and which doesn't involve an external build dependency, then I am open to having build.rs add a old_rustc
cfg flag, and then having a #![cfg_attr(old_rustc, allow(unknown_lints))]
or similar. Unfortunately, I don't see a way to do that.
from ring.
I liked your proposal of removing explicit reference to the lint as it is deny by default. That would resolve this issue.
from ring.
1.78 resolves this issue - so can be closed.
from ring.
Related Issues (20)
- Cranelift struggling with SSE & SSE2 check HOT 2
- Directly support Bazel (and GN) for building instead of Cargo/build.rs
- Unsupported architecture compiling for `aarch64-linux-android` using MacOS SDK 14.2 HOT 2
- evaluation of constant value failed -> assert!(cfg!(target_feature = "sse") && cfg!(target_feature = "sse2")) HOT 1
- Error: dangerous relocation: call8: call target out of range:(xtensa-esp32s3-espidf) HOT 1
- assert!(cfg!(target_feature = "sse") && cfg!(target_feature = "sse2")) panic at build on i386, i586, FreeBSD, or many target_os=none x86 targets. HOT 9
- error: failed to run custom build command for `ring v0.16.20` HOT 1
- Consider using `zeroize` crate for key materials HOT 1
- Build fails on i386: evaluation of constant value failed HOT 1
- failure to verify rsa signature on x509 csr HOT 2
- Fails to build on Linux SPARC HOT 10
- warning: [email protected]: aarch64-fslc-linux-gcc: error: unrecognized command-line option ‘-m64’ HOT 3
- Add riscv64 Support HOT 3
- Disclosure Policy HOT 3
- Attempted to use functionality that requires system randomness!! HOT 1
- warning: [email protected]: Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `C:\Program` installed? HOT 2
- Ring compile error when trying to cross compile from windows 10 to x86_64-unknown-linux-gnu HOT 2
- Ring no longer builds with Rust 1.61 due to cc dependency HOT 1
- support for RISCV32 HOT 4
- `less-safe-getrandom-custom-or-rdrand` not working on target `x86_64-fortanix-unknown-sgx` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ring.