Git Product home page Git Product logo

Comments (7)

csjewell avatar csjewell commented on August 26, 2024

And I was just able to set configuration for the last bit. So things are working for me with the patch.

from mycpan-app-dpan.

briandfoy avatar briandfoy commented on August 26, 2024

Yeah, send PRs.

But also not that in some cases, the system is set up for you to create new modules (or subclasses) to specialize it. These changes look fine for the example modules though.

Which style things bother you?

from mycpan-app-dpan.

briandfoy avatar briandfoy commented on August 26, 2024

Also, I don't think I ever did anything with the mailrc or whois files.

from mycpan-app-dpan.

csjewell avatar csjewell commented on August 26, 2024

Will get the PR's set up tomorrow or the next day, then!

The two things that most surprised me were (A) 8-space indents, instead of 4, and (B) having the brackets that create a block being indented to the same level as their contents (and the left-bracket being on a new line), as opposed to the brackets being the same indentation level as the containing scope and the contents being indented. But I'm also of the opinion of "it's your module, I can live with your formatting" so the PR's will follow where you led.

from mycpan-app-dpan.

briandfoy avatar briandfoy commented on August 26, 2024

It's not an 8-space ident—just a one tab indent. Most editors can deal with that to make it any size that you like.

It's not so bad to write it in any way that you are used to and perltidy it later, though.

from mycpan-app-dpan.

csjewell avatar csjewell commented on August 26, 2024

PR's created, sir! Sorry for not getting them done sooner - had to go into the hospital for a few days.

from mycpan-app-dpan.

briandfoy avatar briandfoy commented on August 26, 2024

I'm closing this is favor of the pull requests you sent.

from mycpan-app-dpan.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.