Comments (5)
@jujaakko I like this idea, I see in your sample KQL you are doing a take 1, my concern here is ensuring we find the right device since there could be more than one device with the right name. I'm thinking we have to put in some more logic here.
If we have an FQDN try to match on the FQDN first
if not fail back to hostname
If more than one match then find the one that's most recently communicated or filter our devices that haven't communicated in x days, if there's multiple devices that have recently communicated with the same name I think we may just need to fail intentionally since we don't really know which device is the correct one
from sentinelautomationmodules.
@piaudonn do you think we should provide an option to disable this enrichment via host name?
from sentinelautomationmodules.
I agree, that would be a problem, this was just the first idea that came to me. Your logic sounds like a good option.
Maybe one solution could be that if there's multiple devices with same name, just make the MDE API query for each of them and return all values? As a user, I think I'd rather have all the information at hand than nothing all. Though this might mess up with the scoring?
from sentinelautomationmodules.
@jujaakko I'll provide a link to the build and instructions early next week as soon as I've tested the build
from sentinelautomationmodules.
@jujaakko the build with this functionality is now published. To update, simply repoint your function app to: https://github.com/briandelmsft/STAT-Function/releases/download/v2.0.8/stat.zip
To repoint the function app, locate the function app in the Azure portal and in the menu click 'Environment variables', click the variable WEBSITE_RUN_FROM_PACKAGE and change the value to https://github.com/briandelmsft/STAT-Function/releases/download/v2.0.8/stat.zip
. Click Apply and then restart the function app
from sentinelautomationmodules.
Related Issues (20)
- [Feature] GrantPermissions - Fail if Connect-MgGraph or Login-AzAccount fail HOT 1
- STATv2 - Remove App Insights from Deployment
- [QUESTION] STATv2 preview without public storage account HOT 1
- [BUG] Wrong data in "ID" variable from MDE-Module - STAT v2 HOT 4
- [QUESTION] STAT V2 AAD Risk Module 403 Forbidden HOT 3
- [BUG] Deploy - Deploy/GrantPermissions.ps1 does not work HOT 8
- [BUG] MDE - Links to entities are broken HOT 2
- [BUG] Base Module - custom entity array incorrectly processed HOT 5
- [Feature] Monitor executions and consumption HOT 1
- [Feature] Suspicious Behaviour Searches HOT 1
- [BUG] STAT Quick Deploy HOT 6
- [BUG] DeployPermissions.ps1 HOT 3
- [Feature] Add tags to incident HOT 1
- [QUESTION] Incident comments - max lines HOT 2
- Function Code Documentation HOT 2
- Suggestion to add more steps into documentation of GrantPermissions.ps1 script HOT 2
- [BUG] Risk Scoring Module - Bug HOT 7
- [Feature] Security Exposure Management module
- [BUG] Permission Script timeout HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentinelautomationmodules.