Git Product home page Git Product logo

Comments (3)

alexbk66 avatar alexbk66 commented on August 10, 2024

Also, _getEnphaseToken calls _refresh_token_cookies which calls _async_fetch_with_retry which in turn calls _getEnphaseToken

from home_assistant_custom_envoy.

briancmpbll avatar briancmpbll commented on August 10, 2024

Hmm, that's a good catch. I didn't write the token fetching logic, but took it from https://github.com/DanBeard/envoy_reader. I should probably fork that repo and separate out the envoy reader code from the component code.

I briefly reviewed the functions you mention and I couldn't figure out why there seems to be circular dependencies between those three functions. Definitely something that needs another look. I'm not sure when I will have time though. If you figure out what's going on while you're porting, please let me know!

from home_assistant_custom_envoy.

alexbk66 avatar alexbk66 commented on August 10, 2024

In my plugin I have the logic separated, i.e. I have separate EnphaseAuthenticator class which uses its own WebClient connection, and the class returns the token and cookies.

This is better to separate the logic especially because the authentication process is a temporary hack, and I don't want to mix its logic with main code.

image

from home_assistant_custom_envoy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.