Upgrade to generic-pool v3 about node-pg-pool HOT 6 CLOSED

Most definitely!

On Sunday, September 18, 2016, James Butler [email protected]
wrote:

It's still not quite finished, but the API changes are all done and
pending any critical bugs should be final.
The big change is the move over to using promises instead of callbacks
(except for the "pooled" function which I still haven't quite worked out
yet)
Minor changes include renaming/removing some config options and
constructor args.

Before I get started on the PR for this, I just wanted to check that your
ok with doing this.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#29, or mute the thread
https://github.com/notifications/unsubscribe-auth/AADDoRmsCpKmNXlPQ7w2wxlQ3d2WiZeHks5qrQ8QgaJpZM4J_3P8
.

from node-pg-pool.

Is the v3 to support acquire time out ?
If I'm correct, this feature is needed to allow to have an error in case of time out with pg.connect.

from node-pg-pool.

@abenhamdine yep, the acquire call timeout support (and ability to more easily add timeouts for other operations) is in the v3 branch. It also isolates factory errors from acquire calls so the two are no longer linked/locked 1:1.

from node-pg-pool.

ah fabulous, can't wait 💃 😄

from node-pg-pool.

ok, finally published the new version after some serious detours. (and already have bugs to deal with!)
@brianc - whats the baseline version of nodejs pg-pool is designed to work with? At the moment, generic-pool v3 requires node v4 because it uses Promises, Sets, Maps and some other es6-isms. With some work it's probably possible to make some version of generic pool (or a module that wraps it) that could shim out those requirements with some < node 4 compatible equivalents.

Thoughts?

from node-pg-pool.

Generic pool has been removed as a dependency. in [email protected]

from node-pg-pool.