Git Product home page Git Product logo

Comments (4)

moritzaugustin avatar moritzaugustin commented on June 11, 2024

The problem might be caused by additional (necessary) changes made by @Kwartke in a series of small patches to the frozen brian2 commit d82e7a4419e61d262126a96dc1bed35e37bac761
You can find these files here: https://github.com/moritzaugustin/brian2/tree/frozen

I think that @Kwartke told me that these changes were integrated into the main repository https://github.com/brian-team/brian2 but I am not sure about this.

@denisalevi Please check whether the patches are really required and if so please do a pull-request to (the current master branch of https://github.com/brian-team/brian2) such that in the final brian2 we can directly import the original brian2 not depending on any additional patches...

The latter would imply -- as far as I understand -- that the submodule track is not useful or that it should rather follow the frozen branch of moritzaugustin/brian2 than of original brian-team/brian2

from brian2cuda.

mstimberg avatar mstimberg commented on June 11, 2024

Hi everyone,
AFAICT, all of @Kwartke's changes to Brian2 have been merged into master already. The merge was in November 2015 but your submodule still tracks the version from October.

from brian2cuda.

moritzaugustin avatar moritzaugustin commented on June 11, 2024

@mstimberg Thanks for the information!

@denisalevi: Since between the commits of @Kwartke into brian-team/brian2 (those which are the most recent three ones in the frozen branch of moritzaugustin/brian2) and d82e7a4419e61d262126a96dc1bed35e37bac761 (commit that the submodule of brian2cuda was/is currently pointing to) there were a couple of other commits to brian-team/brian2. Before we know that also the commits of brian2genn and genn (see README) work with this more recent version we keep it for now as discussed with the frozen branch of moritzaugustin/brian2 and switch then later to the recent brian-team/brian2 when we have solved the open issues.

from brian2cuda.

denisalevi avatar denisalevi commented on June 11, 2024

Yeah, I found the commits in brian2. Thanks @mstimberg.
@moritzaugustin I updated the submodule to track the frozen branch from moritzaugustin/brian2for now.

from brian2cuda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.