Comments (3)
What is the advantage?
from hikaricp.
- less dependency size
- faster initialization (javassist need to parse string containing java code)
anyway it's just proposal
from hikaricp.
While I agree it requires a small dependency, the level at which bytecode generation occurs is simply too low for me. I don't think generating code at the bytecode level such as this:
MethodNode mn = new MethodNode(...);
InsnList il = mn.instructions;
il.add(new VarInsnNode(ILOAD, 1));
LabelNode label = new LabelNode();
il.add(new JumpInsnNode(IFLT, label));
il.add(new VarInsnNode(ALOAD, 0));
il.add(new VarInsnNode(ILOAD, 1));
il.add(new FieldInsnNode(PUTFIELD, "pkg/Bean", "f", "I"));
LabelNode end = new LabelNode();
il.add(new JumpInsnNode(GOTO, end));
il.add(label);
il.add(new FrameNode(F_SAME, 0, null, 0, null));
il.add(new TypeInsnNode(NEW, "java/lang/IllegalArgumentException"));
il.add(new InsnNode(DUP));
il.add(new MethodInsnNode(INVOKESPECIAL,
"java/lang/IllegalArgumentException", "<init>", "()V"));
il.add(new InsnNode(ATHROW));
il.add(end);
il.add(new FrameNode(F_SAME, 0, null, 0, null));
il.add(new InsnNode(RETURN));
mn.maxStack = 2;
mn.maxLocals = 2;
... leads to particularly readable or maintainable code. I'm sure ASM has its place, for example when writing bytecode compilers, but I don't think it is a particularly good for the code generation needs of HikariCP.
from hikaricp.
Related Issues (20)
- PoolBase.quietlyCloseConnection() calls close twice HOT 1
- Encryption in DB Pool Configuration
- support to implement the go version Hikari HOT 1
- Hikari doesnt open more than 10 connections, even when maximumPoolSize and minimumIdle are greater than 10 HOT 2
- The meaning of the indicator is unclear and the relevant definition cannot be found in the source code.
- When I tested the throughput using JMH,found that hikaricp 5.0.0 was faster than version 5.0.1 HOT 1
- Available connections in HikariPool occassionaly drop to zero and not being renewed HOT 7
- In HikariJNDIFactory, int[] type property of DataSource cannot be set.
- PoolEntryCreator logs "Connection not added" when connection is added
- what is the default retry count , that hikari cp does when db is down
- repository @hikaricp which failed to fetch
- Refreshing AADSecurePrincipalSecret dynamically at runtime
- Hooking the connection.close() call HOT 1
- Connection schema is not recovered to settings value when setSchema is used (underline connection is Postgres).
- ability to set exceptionOverride instance, not just class name HOT 1
- hikaricp logs exception, then rethrows it
- Setting Login Timeout While Using HikariDataSource HikariDataSource(HikariConfig configuration) Constructor
- Connection leak in application because it fails to close pooled connections HOT 3
- How to handle OAuth connections that require manually updating the token
- getConnection Method is not throwing exception even when the key is expired HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hikaricp.